[
https://issues.apache.org/jira/browse/DRILL-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879379#comment-16879379
]
ASF GitHub Bot commented on DRILL-7317:
---------------------------------------
arina-ielchiieva commented on pull request #1822: DRILL-7317: Close
ClassLoaders used for udf jars uploading when closing
FunctionImplementationRegistry
URL: https://github.com/apache/drill/pull/1822#discussion_r300728575
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/FunctionRegistryHolder.java
##########
@@ -151,6 +151,20 @@ public void removeJar(String jarName) {
}
}
+ /**
+ * Removes all jars from {@link #jars} map and all associated with jars
functions
+ * from {@link #functions}.
+ * This is write operation, so one user at a time can call perform such
action,
+ * others will wait till first user completes his action.
+ */
+ public void removeAllJars() {
Review comment:
To improve performance please consider adding close method that will just
close appropriate classloaders and then nullify map holders.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Close ClassLoaders used for udf jars uploading when closing
> FunctionImplementationRegistry
> ------------------------------------------------------------------------------------------
>
> Key: DRILL-7317
> URL: https://issues.apache.org/jira/browse/DRILL-7317
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> For the case when {{FunctionImplementationRegistry}} is closed, class loaders
> which were used for uploading jars are still open and don't close file
> descriptors for these jars.
> The proposal is to unregister jars to close its {{ClassLoader}} whenÂ
> {{FunctionImplementationRegistry}} is closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
