[
https://issues.apache.org/jira/browse/DRILL-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881189#comment-16881189
]
ASF GitHub Bot commented on DRILL-6225:
---------------------------------------
debraj92 commented on issue #1817: DRILL-6225: Add support for boost 1.68 with
openSSL 1.1.0/1.1.1 support
URL: https://github.com/apache/drill/pull/1817#issuecomment-509622674
Hi @dgrinchenko ,
Actually the change is incomplete because I ran into a problem with the
travis building. Before explaining the problem, let me answer your questions
and make the idea clear:
1. The purpose of this change is to enable support for openssl 1.1.0/1.1.1.
This requires updating boost (to at least 1.64). So, I updated boost to the
latest - 1.68. But, then I ran into problems with building using travis (as
explained later) and I started experimenting with other versions of boost to
see if the issue can be resolved. Thats why you see 1.65 there in the change.
Ideally it should be 1.68.
2. Agreed, the changes in travis.yml are only experiments to get the build
pass. Will explain the problem shortly.
3. Boost API has changed. The argument now needs to be passed by reference.
This is the main purpose of the change. Without the change drill client code
would not compile with boost 1.68.
Now, the problem. To get travis to build drill client code I would have to
specify the location for downloading the boost 1.68 static libs. I could not
find a repo from where I can do this and hence the change in the travis.yml
file is not accurate. One option is to build boost from source but that would
unnecessarily slow down the build. I also tried other boost versions (1.65,
1.67) but travis build did not succeed. Not sure how to proceed from here now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support
> -----------------------------------------------------------
>
> Key: DRILL-6225
> URL: https://issues.apache.org/jira/browse/DRILL-6225
> Project: Apache Drill
> Issue Type: Task
> Components: Client - C++
> Reporter: Rob Wu
> Assignee: Debraj Ray
> Priority: Minor
>
> Boost 1.57 is not able to compile with openSSL 1.1
> ([https://svn.boost.org/trac10/ticket/12238)] and adding
> add_definitions(-DOPENSSL_API_COMPAT=0x10000000L) does not work.
>
> In order to add support for openSSL 1.1, we would need to upgrade boost to
> 1.62+. However, it looks like boost 1.62 bcp will segfault on asio component
> when you attempt to shade the boost libraries
> ([https://svn.boost.org/trac10/ticket/12357)]. So in that case, we should
> upgrade to 1.64
> +.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
