[
https://issues.apache.org/jira/browse/DRILL-7084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883308#comment-16883308
]
ASF GitHub Bot commented on DRILL-7084:
---------------------------------------
KazydubB commented on pull request #1825: DRILL-7084: ResultSet getObject
method throws not implemented excepti…
URL: https://github.com/apache/drill/pull/1825#discussion_r302711495
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
##########
@@ -78,11 +78,11 @@
* Throws AlreadyClosedSqlException or QueryCanceledSqlException if this
* ResultSet is closed.
*
- * @throws ExecutionCanceledSqlException if ResultSet is closed because of
- * cancelation and no QueryCanceledSqlException has been thrown yet
- * for this ResultSet
- * @throws AlreadyClosedSqlException if ResultSet is closed
- * @throws SQLException if error in calling {@link #isClosed()}
+ * @throws ExecutionCanceledSqlException if ResultSet is closed because of
Review comment:
Previous indentation looks OK. Do you mind undoing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ResultSet getObject method throws not implemented exception if the column
> type is NULL
> --------------------------------------------------------------------------------------
>
> Key: DRILL-7084
> URL: https://issues.apache.org/jira/browse/DRILL-7084
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.15.0
> Reporter: Anton Gozhiy
> Assignee: Anton Gozhiy
> Priority: Major
> Fix For: 1.17.0
>
>
> This method is used by some tools, for example DBeaver. Not reproduced with
> sqlline or Drill Web-UI.
> *Query:*
> {code:sql}
> select coalesce(n_name1, n_name2) from cp.`tpch/nation.parquet` limit 1;
> {code}
> *Expected result:*
> null
> *Actual result:*
> Exception is thrown:
> {noformat}
> java.lang.RuntimeException: not implemented
> at
> oadd.org.apache.calcite.avatica.AvaticaSite.notImplemented(AvaticaSite.java:421)
> at oadd.org.apache.calcite.avatica.AvaticaSite.get(AvaticaSite.java:380)
> at
> org.apache.drill.jdbc.impl.DrillResultSetImpl.getObject(DrillResultSetImpl.java:183)
> at
> org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCResultSetImpl.getObject(JDBCResultSetImpl.java:628)
> at
> org.jkiss.dbeaver.model.impl.jdbc.data.handlers.JDBCObjectValueHandler.fetchColumnValue(JDBCObjectValueHandler.java:60)
> at
> org.jkiss.dbeaver.model.impl.jdbc.data.handlers.JDBCAbstractValueHandler.fetchValueObject(JDBCAbstractValueHandler.java:49)
> at
> org.jkiss.dbeaver.ui.controls.resultset.ResultSetDataReceiver.fetchRow(ResultSetDataReceiver.java:122)
> at
> org.jkiss.dbeaver.runtime.sql.SQLQueryJob.fetchQueryData(SQLQueryJob.java:729)
> at
> org.jkiss.dbeaver.runtime.sql.SQLQueryJob.executeStatement(SQLQueryJob.java:465)
> at
> org.jkiss.dbeaver.runtime.sql.SQLQueryJob.lambda$0(SQLQueryJob.java:392)
> at org.jkiss.dbeaver.model.DBUtils.tryExecuteRecover(DBUtils.java:1598)
> at
> org.jkiss.dbeaver.runtime.sql.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:390)
> at
> org.jkiss.dbeaver.runtime.sql.SQLQueryJob.extractData(SQLQueryJob.java:822)
> at
> org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:2532)
> at
> org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:93)
> at org.jkiss.dbeaver.model.DBUtils.tryExecuteRecover(DBUtils.java:1598)
> at
> org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:91)
> at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:101)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)