[
https://issues.apache.org/jira/browse/DRILL-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897089#comment-16897089
]
ASF GitHub Bot commented on DRILL-7331:
---------------------------------------
ihuzenko commented on pull request #1831: DRILL-7331: Drill Iceberg Metastore
metadata expiration
URL: https://github.com/apache/drill/pull/1831#discussion_r309165067
##########
File path:
metastore/iceberg-metastore/src/main/java/org/apache/drill/metastore/iceberg/IcebergMetastore.java
##########
@@ -75,14 +77,15 @@ public IcebergMetastore(DrillConfig config) {
this.tables = new HadoopTables(new Configuration(configuration));
Review comment:
looks like there is no need to pass ```config``` into
```configuration(config)``` , ```baseLocation(config, ...);``` and
```properties(config, ...)``` because it's usage of field set at first line in
constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Iceberg metadata expiration
> -----------------------------------
>
> Key: DRILL-7331
> URL: https://issues.apache.org/jira/browse/DRILL-7331
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> Currently Iceberg produces snapshots and table metadata for each modification
> operation.
> Plus it does not retire outdated data files. All these information is stored
> and in metadata folder and with time occupy lots of space. This Jira aims to
> expire outdated snapshots, table metadata and data files based on configured
> expiration period.
> Iceberg has already mechanism to retire snapshots and data files. Mechanism
> to expire table metadata needs to be implemented
> (https://github.com/apache/incubator-iceberg/issues/181).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
