[ 
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908269#comment-16908269
 ] 

ASF GitHub Bot commented on DRILL-7350:
---------------------------------------

paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes 
from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-521708575
 
 
   @vvysotskyi, thanks for making this change. It will allow certain other 
tasks to be much easier.
   
   The first observation is that it would be best not to put the RowSet and 
ResultSetLoader stuff in the same package: they represent two independent 
systems and our package naming should make that clear.
   
   Perhaps
   
   1) Rename the existing physical.rowSet to physical.resultSet.
   2) Move the RowSet classes to a new physical.rowSet.
   
   The difference, so we're clear, is that RowSet works on a single batch, 
while the ResultSet works across a stream of batches. If operators, say, want 
to use the row set stuff to read batches, then we need a ResultSetReader that 
automagically handles things like schema changes across batches, etc. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move RowSet related classes from test folder
> --------------------------------------------
>
>                 Key: DRILL-7350
>                 URL: https://issues.apache.org/jira/browse/DRILL-7350
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them 
> for Metastore.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to