[ 
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908300#comment-16908300
 ] 

ASF GitHub Bot commented on DRILL-7350:
---------------------------------------

paul-rogers commented on issue #1843: DRILL-7350: Move RowSet related classes 
from test folder
URL: https://github.com/apache/drill/pull/1843#issuecomment-521715916
 
 
   Two general comments. First, not sure why we needed to convert compact 
single-line methods (a long-time Drill standard) into four-line methods. 
Perhaps this is the result of an overly-helpful code formatter?
   
   Second, looks like a bunch of nested helper classes were moved elsewhere. 
Not sure this is helpful as it clutters the code with small files used in 
exactly one place. The nested classes (a perfectly normal Java practice) makes 
clear that these are, in fact, helpers.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move RowSet related classes from test folder
> --------------------------------------------
>
>                 Key: DRILL-7350
>                 URL: https://issues.apache.org/jira/browse/DRILL-7350
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them 
> for Metastore.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to