[
https://issues.apache.org/jira/browse/DRILL-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920805#comment-16920805
]
ASF GitHub Bot commented on DRILL-7096:
---------------------------------------
ihuzenko commented on pull request #1829: DRILL-7096: Develop vector for
canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r319922866
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java
##########
@@ -149,16 +156,44 @@ public static Builder newBuilder() {
return new Builder();
}
- public static class Builder{
+ public static class Builder {
final IntArrayList ids = new IntArrayList();
MajorType finalType;
MajorType intermediateType;
MajorType secondaryFinal;
PathSegment remainder;
- boolean hyperReader = false;
- boolean withIndex = false;
- boolean isListVector = false;
- Map<Integer, MajorType> types = new HashMap<>();
+ boolean hyperReader;
+ boolean withIndex;
+ boolean isListVector;
+ BitSet dictBitSet = new BitSet();
+
+ public static TypedFieldId build(MajorType type, int... fieldIds) {
+ return new Builder().intermediateType(type)
+ .finalType(type)
+ .secondaryFinal(type)
+ .addIds(fieldIds)
+ .build();
+ }
+
+ public static TypedFieldId build(MajorType type, IntArrayList breadCrumb,
PathSegment remainder) {
+ return new Builder().intermediateType(type)
+ .finalType(type)
+ .secondaryFinal(type)
+ .remainder(remainder)
+ .addIds(breadCrumb.toArray())
+ .build();
+ }
+
+ public static TypedFieldId build(MajorType type, boolean isHyper, int...
fieldIds) {
+ Builder builder = new Builder().intermediateType(type)
+ .finalType(type)
+ .secondaryFinal(type)
+ .addIds(fieldIds);
+ if (isHyper) {
+ builder.hyper();
Review comment:
The ```hyper()``` could simply accept boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Develop vector for canonical Map<K,V>
> -------------------------------------
>
> Key: DRILL-7096
> URL: https://issues.apache.org/jira/browse/DRILL-7096
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Igor Guzenko
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.17.0
>
>
> Canonical Map<K,V> datatype can be represented using combination of three
> value vectors:
> keysVector - vector for storing keys of each map
> valuesVector - vector for storing values of each map
> offsetsVector - vector for storing of start indexes of next each map
> So it's not very hard to create such Map vector, but there is a major issue
> with such map representation. It's hard to search maps values by key in such
> vector, need to investigate some advanced techniques to make such search
> efficient. Or find other more suitable options to represent map datatype in
> world of vectors.
> After question about maps, Apache Arrow developers responded that for Java
> they don't have real Map vector, for now they just have logical Map type
> definition where they define Map like: List< Struct<key:key_type,
> value:value_type> >. So implementation of value vector would be useful for
> Arrow too.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
