[
https://issues.apache.org/jira/browse/DRILL-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930265#comment-16930265
]
ASF GitHub Bot commented on DRILL-7252:
---------------------------------------
arina-ielchiieva commented on pull request #1855: DRILL-7252: Read Hive map
using Dict<K,V> vector
URL: https://github.com/apache/drill/pull/1855#discussion_r324529816
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/writers/complex/HiveMapWriter.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.hive.writers.complex;
+
+import java.util.Map;
+
+import org.apache.drill.exec.store.hive.writers.HiveValueWriter;
+import org.apache.drill.exec.vector.complex.writer.BaseWriter;
+import org.apache.hadoop.hive.serde2.objectinspector.MapObjectInspector;
+
+public class HiveMapWriter implements HiveValueWriter {
+
+ private final MapObjectInspector mapInspector;
+ private final BaseWriter.DictWriter dictWriter;
+ private final HiveValueWriter keyWriter;
+ private final HiveValueWriter valueWriter;
+
+
+ public HiveMapWriter(MapObjectInspector mapInspector, BaseWriter.DictWriter
dictWriter,
+ HiveValueWriter keyWriter, HiveValueWriter valueWriter)
{
+ this.mapInspector = mapInspector;
+ this.dictWriter = dictWriter;
+ this.keyWriter = keyWriter;
+ this.valueWriter = valueWriter;
+ }
+
+ @Override
+ public void write(Object mapHolder) {
+ Map<?, ?> map = mapInspector.getMap(mapHolder);
+ if (map == null) {
+ throw new UnsupportedOperationException("Null map is not supported for
Hive!");
+ }
+ dictWriter.start();
+ map.forEach((key, value) -> {
+ if (key == null || value == null) {
+ throw new UnsupportedOperationException("Null key or value is not
supported for Hive maps!");
Review comment:
```suggestion
throw new UnsupportedOperationException("Null key or value is not
supported in Hive maps.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Read Hive map using Dict<K,V> vector
> ------------------------------------
>
> Key: DRILL-7252
> URL: https://issues.apache.org/jira/browse/DRILL-7252
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Igor Guzenko
> Assignee: Igor Guzenko
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> Described in DRILL-3290 design doc.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
