[
https://issues.apache.org/jira/browse/DRILL-7376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930371#comment-16930371
]
ASF GitHub Bot commented on DRILL-7376:
---------------------------------------
arina-ielchiieva commented on pull request #1856: DRILL-7376: Drill ignores
Hive schema for MaprDB tables when group scan has star column
URL: https://github.com/apache/drill/pull/1856#discussion_r324583334
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
##########
@@ -448,7 +448,11 @@ public int next() {
}
if (nonExistentColumnsProjection && recordCount > 0) {
- JsonReaderUtils.ensureAtLeastOneField(vectorWriter, getColumns(),
schema, allTextMode, Collections.emptyList());
+ if (schema != null && !schema.isEmpty()) {
Review comment:
You can invert condition to avoid negation:
```
if (schema == null || schema.isEmpty()) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Drill ignores Hive schema for MaprDB tables when group scan has star column
> ---------------------------------------------------------------------------
>
> Key: DRILL-7376
> URL: https://issues.apache.org/jira/browse/DRILL-7376
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> For the case when group scan has star column, fix for DRILL-7369 doesn't work
> and hive schema is ignored.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
