[
https://issues.apache.org/jira/browse/DRILL-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946372#comment-16946372
]
ASF GitHub Bot commented on DRILL-7377:
---------------------------------------
paul-rogers commented on pull request #1868: DRILL-7377: Nested schemas for
dynamic EVF columns
URL: https://github.com/apache/drill/pull/1868#discussion_r332299997
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/AbstractTupleWriter.java
##########
@@ -143,6 +144,8 @@ public void dump(HierarchicalFormatter format) {
ObjectWriter addColumn(TupleWriter tuple, MaterializedField field);
}
+ protected static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(AbstractTupleWriter.class);
Review comment:
Done. But note that, when the code was converted from Logback to slf4j, all
of the files ended up with the fully qualified class names. Perhaps someone
should write a script to change all of these if we wish to use qualified names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Can't Create Nested List using EVF with Late Schema
> ---------------------------------------------------
>
> Key: DRILL-7377
> URL: https://issues.apache.org/jira/browse/DRILL-7377
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Charles Givre
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.17.0
>
>
> Looks like the bug is that the code that adds columns on the fly (late
> schema) skips calling the BuildFromSchema step:
> at
> org.apache.drill.exec.physical.resultSet.impl.ColumnBuilder.buildRepeatedList(ColumnBuilder.java:487)
> ~[classes/:na]
> at
> org.apache.drill.exec.physical.resultSet.impl.ColumnBuilder.buildColumn(ColumnBuilder.java:110)
> ~[classes/:na]
> at
> org.apache.drill.exec.physical.resultSet.impl.ContainerState.addColumn(ContainerState.java:93)
> ~[classes/:na]
> at
> org.apache.drill.exec.physical.resultSet.impl.TupleState.addColumn(TupleState.java:505)
> ~[classes/:na]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
