[ 
https://issues.apache.org/jira/browse/DRILL-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949239#comment-16949239
 ] 

ASF GitHub Bot commented on DRILL-7254:
---------------------------------------

KazydubB commented on pull request #1869: DRILL-7254: Read Hive union w/o nulls
URL: https://github.com/apache/drill/pull/1869#discussion_r333845448
 
 

 ##########
 File path: exec/vector/src/main/codegen/templates/UnionVector.java
 ##########
 @@ -561,6 +562,8 @@ public Object getObject(int index) {
         return getMap().getAccessor().getObject(index);
       case MinorType.LIST_VALUE:
         return getList().getAccessor().getObject(index);
+      case MinorType.DICT_VALUE:
 
 Review comment:
   Can you also add `case DICT` to `getMember(MinorType)`, please?
   
   So that looks something like
   ```
   public ValueVector getMember(MinorType type) {
       switch (type) {
         ...
         case DICT:
           return getDict();
         ...
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Read Hive union w/o nulls
> -------------------------
>
>                 Key: DRILL-7254
>                 URL: https://issues.apache.org/jira/browse/DRILL-7254
>             Project: Apache Drill
>          Issue Type: Sub-task
>            Reporter: Igor Guzenko
>            Assignee: Igor Guzenko
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.17.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to