[
https://issues.apache.org/jira/browse/DRILL-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950403#comment-16950403
]
ASF GitHub Bot commented on DRILL-7359:
---------------------------------------
paul-rogers commented on pull request #1870: DRILL-7359: Add support for DICT
type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r334287737
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.record.metadata;
+
+import org.apache.drill.common.types.TypeProtos;
+import org.apache.drill.exec.record.MaterializedField;
+import org.apache.drill.exec.vector.complex.DictVector;
+
+public class DictBuilder implements SchemaContainer {
+
+ private final SchemaContainer parent;
+ private final TupleBuilder tupleBuilder = new TupleBuilder();
+ private final String memberName;
+ private final TypeProtos.DataMode mode;
+
+ public DictBuilder(String memberName, TypeProtos.DataMode mode) {
+ this(null, memberName, mode);
+ }
+
+ public DictBuilder(SchemaContainer parent, String memberName,
TypeProtos.DataMode mode) {
+ this.parent = parent;
+ this.memberName = memberName;
+ this.mode = mode;
+ }
+
+ @Override
+ public void addColumn(ColumnMetadata column) {
+ assert DictVector.fieldNames.contains(column.name());
+ tupleBuilder.addColumn(column);
+ }
+
+ public DictBuilder addKey(TypeProtos.MajorType type) {
+ return add(MaterializedField.create(DictVector.FIELD_KEY_NAME, type));
+ }
+
+ public DictBuilder addValue(TypeProtos.MajorType type) {
+ return add(MaterializedField.create(DictVector.FIELD_VALUE_NAME, type));
+ }
+
+ public DictBuilder add(MaterializedField col) {
+ assert DictVector.fieldNames.contains(col.getName());
+ tupleBuilder.add(col);
+ return this;
+ }
+
+ public DictBuilder addKey(TypeProtos.MinorType type, TypeProtos.DataMode
mode) {
+ tupleBuilder.add(DictVector.FIELD_KEY_NAME, type, mode);
+ return this;
+ }
+
+ public DictBuilder addValue(TypeProtos.MinorType type, TypeProtos.DataMode
mode) {
+ tupleBuilder.add(DictVector.FIELD_VALUE_NAME, type, mode);
+ return this;
+ }
+
+ public DictBuilder addKey(TypeProtos.MinorType type) {
+ tupleBuilder.add(DictVector.FIELD_KEY_NAME, type);
+ return this;
+ }
+
+ public DictBuilder addValue(TypeProtos.MinorType type) {
+ tupleBuilder.add(DictVector.FIELD_VALUE_NAME, type);
+ return this;
+ }
+
+ public DictBuilder addKey(TypeProtos.MinorType type, int width) {
+ tupleBuilder.add(DictVector.FIELD_KEY_NAME, type, width);
+ return this;
+ }
+
+ public DictBuilder addValue(TypeProtos.MinorType type, int width) {
+ tupleBuilder.add(DictVector.FIELD_VALUE_NAME, type, width);
+ return this;
+ }
+
+ public DictBuilder addKey(TypeProtos.MinorType type, int precision, int
scale) {
Review comment:
This form is used for `DECIMAL`. Does it make sense to allow a `DECIMAL` for
a key? Maybe here, and in the width case above, just allow a `MajorType`.
Maybe, in general, the `SchemaBuilder` should have relied on the `Types`
methods to build up such types rather than having methods for each...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for DICT type in RowSet Framework
> ---------------------------------------------
>
> Key: DRILL-7359
> URL: https://issues.apache.org/jira/browse/DRILL-7359
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.17.0
>
>
> Add support for new DICT data type (see DRILL-7096) in RowSet Framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
