[
https://issues.apache.org/jira/browse/DRILL-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960826#comment-16960826
]
ASF GitHub Bot commented on DRILL-7177:
---------------------------------------
arina-ielchiieva commented on pull request #1749: DRILL-7177: Format Plugin for
Excel Files
URL: https://github.com/apache/drill/pull/1749#discussion_r339432072
##########
File path:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java
##########
@@ -901,6 +905,10 @@ private FragmentState(int value) {
* <code>LTSV_SUB_SCAN = 62;</code>
*/
public static final int LTSV_SUB_SCAN_VALUE = 62;
+ /**
+ * <code>EXCEL_SUB_SCAN = 64;</code>
+ */
+ public static final int EXCEL_SUB_SCAN_VALUE = 64;
Review comment:
@cgivre did you generate C++ code, protobuf generating instruction, please
check step 3:
```
If changes are made to the DrillClient's protobuf, you would need to
regenerate the sources for the C++ client as well.
Steps for regenerating the sources are available
https://github.com/apache/drill/blob/master/contrib/native/client/
```
https://github.com/apache/drill/tree/master/protocol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Format Plugin for Excel Files
> -----------------------------
>
> Key: DRILL-7177
> URL: https://issues.apache.org/jira/browse/DRILL-7177
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> This pull request adds the functionality which enables Drill to query
> Microsoft Excel files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
