[
https://issues.apache.org/jira/browse/DRILL-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966322#comment-16966322
]
ASF GitHub Bot commented on DRILL-7436:
---------------------------------------
paul-rogers commented on issue #1889: DRILL-7436: Fix record count, vector
structure issues in several operators
URL: https://github.com/apache/drill/pull/1889#issuecomment-549196906
Sorry for the large number of files changed: the batch count issues are
complex and affect many bits of code.
It may be hard to fully understand why certain things changed. This is why
the `BathValidator` exists: it runs in every unit test to validate each batch,
container and vector. You should assume that the changes all work toward
getting each of the target operators to pass these checks.
Note that many operators are not yet tested. This PR was supposed to just be
the filter operator. But, it turned out that other operators were creating bad
structures for which Filter got the blame. So, the scope had to expand to fix
those upstream problems as well.
Many of the changes, however, are code cleanup and should be quick to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix record count, vector structure issues in several operators
> --------------------------------------------------------------
>
> Key: DRILL-7436
> URL: https://issues.apache.org/jira/browse/DRILL-7436
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
>
> This is the next in a continuing series of fixes to the container record
> count, batch record count, and vector structure in several operators. This
> batch represents the smallest change needed to add checking for the Filter
> operator.
> In order to get Filter to pass checks, many of its upstream operators needed
> to be fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
