[
https://issues.apache.org/jira/browse/DRILL-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966326#comment-16966326
]
ASF GitHub Bot commented on DRILL-7359:
---------------------------------------
paul-rogers commented on pull request #1870: DRILL-7359: Add support for DICT
type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r341884645
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MapBuilder.java
##########
@@ -144,6 +144,14 @@ public RepeatedListBuilder addRepeatedList(String name) {
return tupleBuilder.addRepeatedList(this, name);
}
+ public DictBuilder addDict(String name) {
+ return tupleBuilder.addDict(this, name);
+ }
Review comment:
Maybe `addDict(String name, MinorType keyType)`. Works because the key must
be a scalar and is required. Then the `DictBuilder` simply builds the value
type:
```
scalarValue(MinorType type);
MapBuilder mapValue();
MapBuilder mapArrayValue();
UnionBuilder unionValue();
Foo resumeFoo();
```
Can the value be nullable? (The comment in `DictVector` doesn't say yes or
no.) If nullable is allowed, then only the scalar can be nullable, so maybe add:
```
nullableValue(MinorType type)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for DICT type in RowSet Framework
> ---------------------------------------------
>
> Key: DRILL-7359
> URL: https://issues.apache.org/jira/browse/DRILL-7359
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.17.0
>
>
> Add support for new DICT data type (see DRILL-7096) in RowSet Framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
