Paul Rogers created DRILL-7441: ---------------------------------- Summary: Fix issues with fillEmpties, offset vectors Key: DRILL-7441 URL: https://issues.apache.org/jira/browse/DRILL-7441 Project: Apache Drill Issue Type: Bug Reporter: Paul Rogers Assignee: Paul Rogers
Enable the vector validator with full testing of offset vectors. A number of operators trigger errors. Tracking down the issues, and adding detailed tests, it turns out that: * Drill has an informal standard that zero-length batches should have zero-length offset vectors, while a batch of size 1 will have offset vectors of size 2. Thus, zero-length is a special case. * Nullable, repeated and variable-width vectors have "fill empties" logic that is used in two places: when setting the value count and when preparing to write a new value. The current logic is not quite right for either case. Detailed vector checks fail due to inconsistencies in how the above works. This PR fixes those issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)