[
https://issues.apache.org/jira/browse/DRILL-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974385#comment-16974385
]
ASF GitHub Bot commented on DRILL-7359:
---------------------------------------
KazydubB commented on pull request #1870: DRILL-7359: Add support for DICT type
in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r346400409
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MetadataUtils.java
##########
@@ -205,4 +205,10 @@ private static ColumnMetadata newDecimal(String name,
MinorType type, DataMode m
return new PrimitiveColumnMetadata(field);
}
+ private static boolean isScalar(MinorType type) {
+ return type != MinorType.MAP
+ && type != MinorType.UNION
+ && type != MinorType.LIST
+ && type != MinorType.DICT;
+ }
Review comment:
Yeah, much negation... Changed the body of the method - didn't want to
introduce the new `isComplex()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for DICT type in RowSet Framework
> ---------------------------------------------
>
> Key: DRILL-7359
> URL: https://issues.apache.org/jira/browse/DRILL-7359
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.17.0
>
>
> Add support for new DICT data type (see DRILL-7096) in RowSet Framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
