[
https://issues.apache.org/jira/browse/DRILL-7441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975123#comment-16975123
]
ASF GitHub Bot commented on DRILL-7441:
---------------------------------------
vvysotskyi commented on pull request #1896: DRILL-7441: Fix issues with
fillEmpties, offset vectors
URL: https://github.com/apache/drill/pull/1896#discussion_r345188398
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetPrinter.java
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.physical.rowSet;
+
+import java.io.PrintStream;
+
+import org.apache.drill.exec.record.BatchSchema.SelectionVectorMode;
+import org.apache.drill.exec.record.RecordBatch;
+import org.apache.drill.exec.record.VectorContainer;
+import org.apache.drill.exec.record.metadata.ColumnMetadata;
+import org.apache.drill.exec.record.metadata.TupleMetadata;
+
+/**
+ * Print a row set in CSV-like format. Primarily for debugging.
+ */
+
+public class RowSetPrinter {
Review comment:
The same objection as in https://github.com/apache/drill/pull/1897.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix issues with fillEmpties, offset vectors
> -------------------------------------------
>
> Key: DRILL-7441
> URL: https://issues.apache.org/jira/browse/DRILL-7441
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
>
> Enable the vector validator with full testing of offset vectors. A number of
> operators trigger errors. Tracking down the issues, and adding detailed
> tests, it turns out that:
> * Drill has an informal standard that zero-length batches should have
> zero-length offset vectors, while a batch of size 1 will have offset vectors
> of size 2. Thus, zero-length is a special case.
> * Nullable, repeated and variable-width vectors have "fill empties" logic
> that is used in two places: when setting the value count and when preparing
> to write a new value. The current logic is not quite right for either case.
> Detailed vector checks fail due to inconsistencies in how the above works.
> This PR fixes those issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
