[
https://issues.apache.org/jira/browse/DRILL-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976877#comment-16976877
]
ASF GitHub Bot commented on DRILL-7388:
---------------------------------------
arina-ielchiieva commented on issue #1901: DRILL-7388: Kafka improvements
URL: https://github.com/apache/drill/pull/1901#issuecomment-555204411
@vvysotskyi / @paul-rogers thanks for the code review. Addressed code review
comments.
@paul-rogers regarding moving Kafka to EVF, does it depend on Json format
conversion to EVF or `org.apache.drill.exec.vector.complex.fn.JsonReader` won't
be changed only code which is using it? Also looks like we have a couple of
examples of format plugins on EVF, do we have EVF based plugins? Only Mock
plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Apache Drill Kafka Storage module fails to return results for partitions
> containing single offset record
> --------------------------------------------------------------------------------------------------------
>
> Key: DRILL-7388
> URL: https://issues.apache.org/jira/browse/DRILL-7388
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: daniel kelly
> Assignee: Arina Ielchiieva
> Priority: Major
> Fix For: 1.17.0
>
>
> If a partition only contains one record - e.g.
> [topicName=myTopic, partitionId=117, startOffset=0, endOffset=1]
> no data is returned.
> I fixed this locally with the following code change in contrib/storage-kafka
> :-
> {code:java}
> git diff
> src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
> @@ -109,7 +109,7 @@ public class KafkaRecordReader extends
> AbstractRecordReader {
> currentMessageCount = 0;
>
> try {
> - while (currentOffset < subScanSpec.getEndOffset() - 1 &&
> msgItr.hasNext()) {
> + while (currentOffset < subScanSpec.getEndOffset() && msgItr.hasNext())
> {
> ConsumerRecord<byte[], byte[]> consumerRecord = msgItr.next();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
