[
https://issues.apache.org/jira/browse/DRILL-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977591#comment-16977591
]
ASF GitHub Bot commented on DRILL-7448:
---------------------------------------
arina-ielchiieva commented on issue #1902: DRILL-7448: Fix warnings when
running Drill memory tests
URL: https://github.com/apache/drill/pull/1902#issuecomment-555522348
@KazydubB thanks for making the changes. Discussed this issue with
@vvysotskyi, it looks like adding janino dependency in all modules (and then
control that it is added in new ones), might be slightly an overhead. I
understand that we need to do this to support conditional processing which is
mainly used to enable Lilith. On the other hand, we can remove condition, and
leave Lilith code commented. Those who need Lilith would have to uncomment this
code, instead of setting the variable. I suspect Lilith usage is not that
popular in project and there won't be many complaints about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix warnings when running Drill memory tests
> --------------------------------------------
>
> Key: DRILL-7448
> URL: https://issues.apache.org/jira/browse/DRILL-7448
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Arina Ielchiieva
> Assignee: Bohdan Kazydub
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> {noformat}
> -- drill-memory-base
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> [INFO] Running org.apache.drill.exec.memory.TestEndianess
> [INFO] Running org.apache.drill.exec.memory.TestAccountant
> 16:21:45,719 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Could
> NOT find resource [logback.groovy]
> 16:21:45,719 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found
> resource [logback-test.xml] at
> [jar:file:/Users/arina/Development/git_repo/drill/common/target/drill-common-1.17.0-SNAPSHOT-tests.jar!/logback-test.xml]
> 16:21:45,733 |-INFO in
> ch.qos.logback.core.joran.spi.ConfigurationWatchList@dbd940d - URL
> [jar:file:/Users/arina/Development/git_repo/drill/common/target/drill-common-1.17.0-SNAPSHOT-tests.jar!/logback-test.xml]
> is not of type file
> 16:21:45,780 |-INFO in
> ch.qos.logback.classic.joran.action.ConfigurationAction - debug attribute not
> set
> 16:21:45,802 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction -
> Could not find Janino library on the class path. Skipping conditional
> processing.
> 16:21:45,802 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction - See
> also http://logback.qos.ch/codes.html#ifJanino
> 16:21:45,803 |-INFO in ch.qos.logback.core.joran.action.AppenderAction -
> About to instantiate appender of type [ch.qos.logback.core.ConsoleAppender]
> 16:21:45,811 |-INFO in ch.qos.logback.core.joran.action.AppenderAction -
> Naming appender as [STDOUT]
> 16:21:45,826 |-INFO in
> ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming default
> type [ch.qos.logback.classic.encoder.PatternLayoutEncoder] for [encoder]
> property
> 16:21:45,866 |-INFO in ch.qos.logback.classic.joran.action.LevelAction - ROOT
> level set to ERROR
> 16:21:45,866 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction -
> Could not find Janino library on the class path. Skipping conditional
> processing.
> 16:21:45,866 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction - See
> also http://logback.qos.ch/codes.html#ifJanino
> 16:21:45,866 |-WARN in ch.qos.logback.classic.joran.action.RootLoggerAction -
> The object on the top the of the stack is not the root logger
> 16:21:45,866 |-WARN in ch.qos.logback.classic.joran.action.RootLoggerAction -
> It is: ch.qos.logback.core.joran.conditional.IfAction
> 16:21:45,866 |-INFO in
> ch.qos.logback.classic.joran.action.ConfigurationAction - End of
> configuration.
> 16:21:45,867 |-INFO in
> ch.qos.logback.classic.joran.JoranConfigurator@71d15f18 - Registering current
> configuration as safe fallback point
> 16:21:45,717 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Could
> NOT find resource [logback.groovy]
> 16:21:45,717 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found
> resource [logback-test.xml] at
> [jar:file:/Users/arina/Development/git_repo/drill/common/target/drill-common-1.17.0-SNAPSHOT-tests.jar!/logback-test.xml]
> 16:21:45,729 |-INFO in
> ch.qos.logback.core.joran.spi.ConfigurationWatchList@2698dc7 - URL
> [jar:file:/Users/arina/Development/git_repo/drill/common/target/drill-common-1.17.0-SNAPSHOT-tests.jar!/logback-test.xml]
> is not of type file
> 16:21:45,778 |-INFO in
> ch.qos.logback.classic.joran.action.ConfigurationAction - debug attribute not
> set
> 16:21:45,807 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction -
> Could not find Janino library on the class path. Skipping conditional
> processing.
> 16:21:45,807 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction - See
> also http://logback.qos.ch/codes.html#ifJanino
> 16:21:45,808 |-INFO in ch.qos.logback.core.joran.action.AppenderAction -
> About to instantiate appender of type [ch.qos.logback.core.ConsoleAppender]
> 16:21:45,814 |-INFO in ch.qos.logback.core.joran.action.AppenderAction -
> Naming appender as [STDOUT]
> 16:21:45,829 |-INFO in
> ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming default
> type [ch.qos.logback.classic.encoder.PatternLayoutEncoder] for [encoder]
> property
> 16:21:45,868 |-INFO in ch.qos.logback.classic.joran.action.LevelAction - ROOT
> level set to ERROR
> 16:21:45,868 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction -
> Could not find Janino library on the class path. Skipping conditional
> processing.
> 16:21:45,868 |-ERROR in ch.qos.logback.core.joran.conditional.IfAction - See
> also http://logback.qos.ch/codes.html#ifJanino
> 16:21:45,868 |-WARN in ch.qos.logback.classic.joran.action.RootLoggerAction -
> The object on the top the of the stack is not the root logger
> 16:21:45,868 |-WARN in ch.qos.logback.classic.joran.action.RootLoggerAction -
> It is: ch.qos.logback.core.joran.conditional.IfAction
> 16:21:45,868 |-INFO in
> ch.qos.logback.classic.joran.action.ConfigurationAction - End of
> configuration.
> 16:21:45,869 |-INFO in
> ch.qos.logback.classic.joran.JoranConfigurator@43d7741f - Registering current
> configuration as safe fallback point
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
