[
https://issues.apache.org/jira/browse/DRILL-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978516#comment-16978516
]
ASF GitHub Bot commented on DRILL-5844:
---------------------------------------
arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of
TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API
URL: https://github.com/apache/drill/pull/1904#issuecomment-556054184
> Hi @arjuntheprogrammer , there are a lot of possible options how to check
your fix. One simplest example for **TestJdbcPluginWithH2IT.java** is :
>
> ```java
> @Test
> public void testJdbcTableTypes() throws Exception {
> String query = "select distinct table_type from
information_schema.`tables` " +
> "where table_schema like 'h2%'";
> testBuilder()
> .sqlQuery(query)
> .unOrdered()
> .baselineColumns("table_type")
> .baselineValuesForSingleColumn("SYSTEM TABLE", "TABLE")
> .go();
> }
> ```
>
> similar test could be added to **TestJdbcPluginWithMySQLIT.java**, you'll
only need to change where condition to `mysql%` and update expected results.
@ihuzenko - I have written the test function in both of the files, and build
and test on Travis CI also passed.
Please let me know if this issue requires any other changes.
Thanks for your help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Incorrect values of TABLE_TYPE returned from method
> DatabaseMetaData.getTables of JDBC API
> ------------------------------------------------------------------------------------------
>
> Key: DRILL-5844
> URL: https://issues.apache.org/jira/browse/DRILL-5844
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC, Metadata
> Affects Versions: 1.10.0
> Reporter: second88
> Assignee: Arjun Gupta
> Priority: Minor
> Fix For: 1.17.0
>
>
> As far as I can see, the values of TABLE_TYPE returned from method
> DatabaseMetaData.getTables of JDBC API of a Drill Connection include:
> TABLE
> VIEW
> SYSTEM_TABLE
> According to [JDBC
> API|http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTables(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String\[\])],
> the typical types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY",
> "LOCAL TEMPORARY", "ALIAS", "SYNONYM".
> Therefore "SYSTEM_TABLE" should be replaced by "SYSTEM TABLE".
> Besides, I wonder if this bug is related to another bug
> [DRILL-5843|https://issues.apache.org/jira/browse/DRILL-5843] reported by me.
> It should be noted that the values of TABLE_TYPE returned from methods
> DatabaseMetaData.getTables and DatabaseMetaData.getTableTypes should be
> one-to-one matched with but may not be the same as those in
> INFORMATION_SCHEMA.TABLES.TABLE_TYPE, for instance, "TABLE" VS "BASE TABLE".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
