[
https://issues.apache.org/jira/browse/DRILL-7393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986400#comment-16986400
]
ASF GitHub Bot commented on DRILL-7393:
---------------------------------------
agozhiy commented on issue #1910: DRILL-7393: Revisit Drill tests to ensure
that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#issuecomment-560639306
@paul-rogers, the approach you suggested is reasonable and actually it is
similar to the one used in Drill now. But it doesn't solve the original issue.
Let me describe it:
**Prerequisites:**
- In java-exec module we have both tests that require patching (or use
Drillbit) and standalone tests that don't need patching but might use some
Guava classes (e.g. Closeables)
**Steps:**
1. Run tests by command:
`mvn clean test -pl exec/java-exec -DforkCount=4`
Changing forkCount is needed to increase probability of race conditions.
2. Wait for failures.
**Expected result:**
Tests are passed.
**Actual result:**
Some tests will fail because patching didn't happen.
So, let's see what is happening here:
As we cannot guarantee the tests execution order, it is quite possible that
a test that doesn't init patching will run first. It is also possible that this
test is using some Guava class inside (and it'll be loaded during the test
execution). Once the class is loaded it cannot be patched (Javassist constructs
a modified class, attempts to load it and fail with error "attempted duplicate
class definition for name"). Then, all patching-dependent tests will fail. I
hope my explanation is clear.
P.S.: Thank you for the feedback!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Revisit Drill tests to ensure that patching is executed before any test run
> ---------------------------------------------------------------------------
>
> Key: DRILL-7393
> URL: https://issues.apache.org/jira/browse/DRILL-7393
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.16.0, 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Anton Gozhiy
> Priority: Major
> Labels: ready-to-commit
>
> Apache Drill patches some Protobuf and Guava classes (see GuavaPatcher,
> ProtobufPatcher), patching should be done before classes to be patched are
> loaded. That's why this operation is executed in static block in Drillbit
> class.
> Some tests in java-exec module use Drillbit class, some extend DrillTest
> class, both of them patch Guava. But there are some tests that do not call
> patcher but load classes to be patched. For example,
> {{org.apache.drill.exec.sql.TestSqlBracketlessSyntax}} loads Guava
> Preconditions class. If such tests run before tests that require patching,
> tests run will fail since patching won't be successful. Patchers code does
> not fail application if patching was not complete, just logs warning
> ({{logger.warn("Unable to patch Guava classes.", e);}}), so sometimes it hard
> to identify unit tests failure root cause.
> We need to revisit all Drill tests to ensure that all of them extend common
> test base class which patchers Protobuf and Guava classes in static block.
> Also refactor Patcher classes to have assert to fail if patching fails during
> unit testing if there are any problems.
> After all tests are revised, we can remove {{metastore-test}} execution from
> main.xml in {{maven-surefire-plugin}} which was added to ensure that all
> Metastore tests run in a separate JVM where patching is done in first place
> since Iceberg Metastore heavily depends on patched Guava Preconditions class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
