[
https://issues.apache.org/jira/browse/DRILL-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994261#comment-16994261
]
ASF GitHub Bot commented on DRILL-7476:
---------------------------------------
paul-rogers commented on issue #1922: DRILL-7476: Set lastSet on TransferPair
copies
URL: https://github.com/apache/drill/pull/1922#issuecomment-564864142
@vvysotskyi, I had a nice unit test that I used when debugging. However, it
turns out that we can't use it in Maven: the information in the system table
('connections') changes too much. (One row for one connection when run in the
IDE, but 9 (?) rows when run in Maven.)
I can perhaps add a different test: the problem should appear anytime a
`LIMIT` is done where the limit amount is the same as the row count. But, to
create such a test, I'll need to do it on master before this fix (to verify
that the test catches the error.)
Even better, this PR does include a new batch check that *did* catch the
error. If the error occurs, all offsets in a VARCHAR offset vector will be 0. A
check verifies that the largest offset is the same size as the data vector. If
this bug occurs, that check will trigger and we'll see an error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Info in some sys schema tables are missing if queried with limit clause
> -----------------------------------------------------------------------
>
> Key: DRILL-7476
> URL: https://issues.apache.org/jira/browse/DRILL-7476
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Paul Rogers
> Priority: Blocker
> Fix For: 1.17.0
>
>
> Affected schema: sys
> Affected tables: connections, threads, memory
> If query is executed with limit clause, information for some fields is
> missing:
> *Connections*
> {noformat}
> apache drill (sys)> select * from connections;
> +-----------+---------------+------------+-------------------------+-------------------+---------+-----------------+-------------+----------+--------------------------------------+
> | user | client | drillbit | established |
> duration | queries | isAuthenticated | isEncrypted | usingSSL |
> session |
> +-----------+---------------+------------+-------------------------+-------------------+---------+-----------------+-------------+----------+--------------------------------------+
> | anonymous | xxx.xxx.x.xxx | xxx | 2019-12-10 13:45:01.766 | 59 min 42.393
> sec | 27 | false | false | false | xxx |
> +-----------+---------------+------------+-------------------------+-------------------+---------+-----------------+-------------+----------+--------------------------------------+
> 1 row selected (0.1 seconds)
> apache drill (sys)> select * from connections limit 1;
> +------+--------+----------+-------------------------+----------+---------+-----------------+-------------+----------+---------+
> | user | client | drillbit | established | duration | queries |
> isAuthenticated | isEncrypted | usingSSL | session |
> +------+--------+----------+-------------------------+----------+---------+-----------------+-------------+----------+---------+
> | | | | 2019-12-10 13:45:01.766 | | 28 |
> false | false | false | |
> +------+--------+----------+-------------------------+----------+---------+-----------------+-------------+----------+---------+
> {noformat}
> *Threads*
> {noformat}
> apache drill (sys)> select * from threads;
> +------------+-----------+---------------+--------------+
> | hostname | user_port | total_threads | busy_threads |
> +------------+-----------+---------------+--------------+
> | xxx | 31010 | 27 | 23 |
> +------------+-----------+---------------+--------------+
> 1 row selected (0.119 seconds)
> apache drill (sys)> select * from threads limit 1;
> +----------+-----------+---------------+--------------+
> | hostname | user_port | total_threads | busy_threads |
> +----------+-----------+---------------+--------------+
> | | 31010 | 27 | 24 |
> {noformat}
> *Memory*
> {noformat}
> apache drill (sys)> select * from memory;
> +------------+-----------+--------------+------------+----------------+--------------------+------------+
> | hostname | user_port | heap_current | heap_max | direct_current |
> jvm_direct_current | direct_max |
> +------------+-----------+--------------+------------+----------------+--------------------+------------+
> | xxx | 31010 | 493974480 | 4116185088 | 5048576 | 122765
> | 8589934592 |
> +------------+-----------+--------------+------------+----------------+--------------------+------------+
> 1 row selected (0.115 seconds)
> apache drill (sys)> select * from memory limit 1;
> +----------+-----------+--------------+------------+----------------+--------------------+------------+
> | hostname | user_port | heap_current | heap_max | direct_current |
> jvm_direct_current | direct_max |
> +----------+-----------+--------------+------------+----------------+--------------------+------------+
> | | 31010 | 499343272 | 4116185088 | 9048576 | 122765
> | 8589934592 |
> +----------+-----------+--------------+------------+----------------+--------------------+------------+
> {noformat}
> When selecting data from *Drillbits* table which has similar fields (ex:
> hostname), everything is fine:
> {noformat}
> apache drill (sys)> select * from drillbits;
> +------------+-----------+--------------+-----------+-----------+---------+---------+--------+
> | hostname | user_port | control_port | data_port | http_port | current |
> version | state |
> +------------+-----------+--------------+-----------+-----------+---------+---------+--------+
> | xxx | 31010 | 31011 | 31012 | 8047 | true | 1.17.0
> | ONLINE |
> +------------+-----------+--------------+-----------+-----------+---------+---------+--------+
> 1 row selected (0.114 seconds)
> apache drill (sys)> select * from drillbits limit 1;
> +------------+-----------+--------------+-----------+-----------+---------+---------+--------+
> | hostname | user_port | control_port | data_port | http_port | current |
> version | state |
> +------------+-----------+--------------+-----------+-----------+---------+---------+--------+
> | xxx | 31010 | 31011 | 31012 | 8047 | true | 1.17.0
> | ONLINE |
> +------------+-----------+--------------+-----------+-----------+---------+---------+--------+
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
