[
https://issues.apache.org/jira/browse/DRILL-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995561#comment-16995561
]
ASF GitHub Bot commented on DRILL-7486:
---------------------------------------
arina-ielchiieva commented on pull request #1928: DRILL-7486: Refactor row set
reader builders
URL: https://github.com/apache/drill/pull/1928#discussion_r357611309
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/HyperRowIndex.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.physical.rowSet;
+
+import org.apache.drill.exec.physical.resultSet.model.ReaderIndex;
+import org.apache.drill.exec.record.selection.SelectionVector4;
+import org.apache.drill.exec.vector.accessor.impl.AccessorUtilities;
+
+/**
+ * Read-only row index into the hyper row set with batch and index
+ * values mapping via an SV4.
+ */
+
+public class HyperRowIndex extends ReaderIndex {
+
+ private final SelectionVector4 sv4;
+
+ public HyperRowIndex(SelectionVector4 sv4) {
+ super(sv4.getCount());
+ this.sv4 = sv4;
+ }
+
+ @Override
+ public int offset() {
+ return AccessorUtilities.sv4Index(sv4.get(position));
+ }
+
+ @Override
+ public int hyperVectorIndex( ) {
+ return AccessorUtilities.sv4Batch(sv4.get(position));
+ }
+}
Review comment:
New line in the end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Restructure row set reader builder
> ----------------------------------
>
> Key: DRILL-7486
> URL: https://issues.apache.org/jira/browse/DRILL-7486
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
>
> The code to build a row set reader is located in several places, and is tied
> to the {{RowSet}} class for historical reasons. This restructuring pulls out
> the code so it can be used from a {{VectorContainer}} or other source.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
