[ 
https://issues.apache.org/jira/browse/DRILL-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997197#comment-16997197
 ] 

ASF GitHub Bot commented on DRILL-7483:
---------------------------------------

arina-ielchiieva commented on pull request #1935: DRILL-7483: Add support for 
12 and 13 java versions
URL: https://github.com/apache/drill/pull/1935#discussion_r358183732
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/BatchValidator.java
 ##########
 @@ -173,6 +173,10 @@ public BatchValidator(ErrorReporter errorReporter) {
   }
 
   public static boolean validate(RecordBatch batch) {
+    // This is a handy place to trace batches as they flow up
+    // the DAG. Works best for single-threaded runs with few records.
 
 Review comment:
   Don't we have some print method for this case? So we don't need to make 
changes in code?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add support for 12 and 13 java versions
> ---------------------------------------
>
>                 Key: DRILL-7483
>                 URL: https://issues.apache.org/jira/browse/DRILL-7483
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build & Test
>    Affects Versions: 1.16.0
>            Reporter: Vitalii Diravka
>            Assignee: Vova Vysotskyi
>            Priority: Major
>             Fix For: 1.17.0
>
>
> The latest versions are Java 13, released in October 2019
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce 
> (validate_java_and_maven_version) @ drill-root ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed 
> with message:
> Detected JDK Version: 13.0.1 is not in the allowed range [1.8,12)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to