[
https://issues.apache.org/jira/browse/DRILL-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003844#comment-17003844
]
ASF GitHub Bot commented on DRILL-7359:
---------------------------------------
paul-rogers commented on pull request #1870: DRILL-7359: Add support for DICT
type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r361565139
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/ContainerState.java
##########
@@ -172,4 +172,8 @@ public void close() {
colState.close();
}
}
+
+ public boolean isDict() {
+ return false;
+ }
Review comment:
Should clients of this class care what kind of container this is? Shouldn't
all DICT-specific code be in the DICT related classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for DICT type in RowSet Framework
> ---------------------------------------------
>
> Key: DRILL-7359
> URL: https://issues.apache.org/jira/browse/DRILL-7359
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.18.0
>
>
> Add support for new DICT data type (see DRILL-7096) in RowSet Framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
