[
https://issues.apache.org/jira/browse/DRILL-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-7467:
------------------------------------
Description:
This Jira incorporates several JDBC plugin enhancements and fixes:
1. Drill does not close DB connection when JDBC storage plugin is disabled:
JdbcStoragePlugin does not implement the 'close' method, leaving all
connections open even after the plugin is disabled. This could be monitored
through 'lsof' command. Restarting a JDBC plugin adds to existing connections
and Drill restart is required to release all TCP connections.
2. Add rdbms / jdbc plugin disables template to the boostrap storage plugins.
3. Add new jdbc storage plugin configuration property {{sourceParameters}}
which will allow setting data source parameters described in [BasicDataSource
Configuration
Parameters|https://commons.apache.org/proper/commons-dbcp/configuration.html].
Parameters names with incorrect naming will be ignored during plugin
configuration,
parameter value which are of incorrect data type or illegal will fail storage
plugin to start up.
Example: of {{sourceParameters}} section in storage plugin configuration:
{noformat}
"sourceParameters" : {
"maxIdle" : 8,
"cacheState": true,
"validationQuery": "select * from information_schema.collations"
},
{noformat}
4. Upgraded {{commons-dbcp2}} version and added it to the dependency management
section in common pom.xml.
was:
This Jira incorporates several JDBC plugin enhancements and fixes:
1. Drill does not close DB connection when JDBC storage plugin is disabled:
JdbcStoragePlugin does not implement the 'close' method, leaving all
connections open even after the plugin is disabled. This could be monitored
through 'lsof' command. Restarting a JDBC plugin adds to existing connections
and Drill restart is required to release all TCP connections.
2. Add rdbms / jdbc plugin disables template to the boostrap storage plugins.
3. Add new jdbc storage plugin configuration property {{sourceParameters}}
which will allow setting data source parameters described in [BasicDataSource
Configuration
Parameters|https://commons.apache.org/proper/commons-dbcp/configuration.html].
Parameters names with incorrect naming will be ignored during plugin
configuration,
parameter value which are of incorrect data type or illegal will fail storage
plugin to start up.
Example: of {{sourceParameters}} section in storage plugin configuration:
{noformat}
"sourceParameters" : {
"maxIdle" : 8,
"cacheState": true,
"validationQuery": "select * from information_schema.collations"
},
{noformat}
4. Upgraded {{commons-dbcp2}} version and added it to the dependency management
section in common pom.xml.
> Jdbc plugin enhancements and fixes
> ----------------------------------
>
> Key: DRILL-7467
> URL: https://issues.apache.org/jira/browse/DRILL-7467
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
> Affects Versions: 1.17.0
> Reporter: Priyanka Bhoir
> Assignee: Arina Ielchiieva
> Priority: Major
> Fix For: 1.18.0
>
>
> This Jira incorporates several JDBC plugin enhancements and fixes:
> 1. Drill does not close DB connection when JDBC storage plugin is disabled:
> JdbcStoragePlugin does not implement the 'close' method, leaving all
> connections open even after the plugin is disabled. This could be monitored
> through 'lsof' command. Restarting a JDBC plugin adds to existing connections
> and Drill restart is required to release all TCP connections.
> 2. Add rdbms / jdbc plugin disables template to the boostrap storage plugins.
> 3. Add new jdbc storage plugin configuration property {{sourceParameters}}
> which will allow setting data source parameters described in [BasicDataSource
> Configuration
> Parameters|https://commons.apache.org/proper/commons-dbcp/configuration.html].
> Parameters names with incorrect naming will be ignored during plugin
> configuration,
> parameter value which are of incorrect data type or illegal will fail storage
> plugin to start up.
> Example: of {{sourceParameters}} section in storage plugin configuration:
> {noformat}
> "sourceParameters" : {
> "maxIdle" : 8,
> "cacheState": true,
> "validationQuery": "select * from information_schema.collations"
> },
> {noformat}
> 4. Upgraded {{commons-dbcp2}} version and added it to the dependency
> management section in common pom.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
