[
https://issues.apache.org/jira/browse/DRILL-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019623#comment-17019623
]
ASF GitHub Bot commented on DRILL-7458:
---------------------------------------
arina-ielchiieva commented on pull request #1914: DRILL-7458: Base framework
for storage plugins
URL: https://github.com/apache/drill/pull/1914#discussion_r368566269
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/base/DummyStoragePluginConfig.java
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.base;
+
+import org.apache.drill.common.logical.StoragePluginConfig;
+import org.apache.drill.shaded.guava.com.google.common.base.Objects;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+
+/**
+ * Options for the "test mule" storage plugin. The options
+ * control how the plugin behaves for testing. A real plugin
+ * would simply implement project push down, and, if filter push-down
+ * is needed, would implement one of the strategies described
+ * here.
+ */
+
+@JsonTypeName(DummyStoragePluginConfig.NAME)
+@JsonPropertyOrder({"enableProjectPushDown", "enableFilterPushDown",
+ "keepFilters", "enable"})
+public class DummyStoragePluginConfig extends StoragePluginConfig {
+
+ public static final String NAME = "dummy";
+
+ /**
+ * Whether to enable or disable project push down.
+ */
+ private final boolean enableProjectPushDown;
+
+ /**
+ * Whether to enable or disable filter push down.
+ */
+ private final boolean enableFilterPushDown;
+
+ /**
+ * When doing filter push-down, whether to keep the filters in
+ * the plan, or remove them (because they are done (simulated)
+ * in the reader.
+ */
+
+ private final boolean keepFilters;
+
+ public DummyStoragePluginConfig(
+ @JsonProperty("enableProjectPushDown") boolean enableProjectPushDown,
+ @JsonProperty("enableFilterPushDown") boolean enableFilterPushDown,
+ @JsonProperty("keepFilters") boolean keepFilters) {
+ this.enableProjectPushDown = enableProjectPushDown;
+ this.enableFilterPushDown = enableFilterPushDown;
+ this.keepFilters = keepFilters;
+ setEnabled(true);
+ }
+
+ @JsonProperty("enableProjectPushDown")
+ public boolean enableProjectPushDown() { return enableProjectPushDown; }
+
+ @JsonProperty("enableFilterPushDown")
+ public boolean enableFilterPushDown() { return enableFilterPushDown; }
+
+ @JsonProperty("keepFilters")
+ public boolean keepFilters() { return keepFilters; }
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == this) {
+ return true;
+ }
+ if (o == null || !(o instanceof DummyStoragePluginConfig)) {
+ return false;
+ }
+ DummyStoragePluginConfig other = (DummyStoragePluginConfig) o;
+ return enableProjectPushDown == other.enableProjectPushDown &&
+ enableFilterPushDown == other.enableFilterPushDown &&
+ keepFilters == other.keepFilters;
+ }
+
+ @Override
+ public int hashCode() {
Review comment:
Though IDE generates otherwise, it's more common to have hashCode before
equals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Base storage plugin framework
> -----------------------------
>
> Key: DRILL-7458
> URL: https://issues.apache.org/jira/browse/DRILL-7458
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.18.0
>
>
> The "Easy" framework allows third-parties to add format plugins to Drill with
> moderate effort. (The process could be easier, but "Easy" makes it as simple
> as possible given the current structure.)
> At present, no such "starter" framework exists for storage plugins. Further,
> multiple storage plugins have implemented filter push down, seemingly by
> copying large blocks of code.
> This ticket offers a "base" framework for storage plugins and for filter
> push-downs. The framework builds on the EVF, allowing plugins to also support
> project push down.
> The framework has a "test mule" storage plugin to verify functionality, and
> was used as the basis of an REST-like plugin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
