[
https://issues.apache.org/jira/browse/DRILL-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019666#comment-17019666
]
ASF GitHub Bot commented on DRILL-7530:
---------------------------------------
vvysotskyi commented on pull request #1957: DRILL-7530: Fix class names in
loggers
URL: https://github.com/apache/drill/pull/1957#discussion_r368673238
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
##########
@@ -603,7 +606,7 @@ public static boolean guessRows(RelNode rel) {
|| (tableMetadata = table.getGroupScan().getTableMetadata()) ==
null
||
!TableStatisticsKind.HAS_DESCRIPTIVE_STATISTICS.getValue(tableMetadata);
} catch (IOException e) {
- RelOptPlanner.LOGGER.debug("Unable to obtain table metadata due to
exception:", e);
+ logger.debug("Unable to obtain table metadata due to exception: {}",
e.getMessage(), e);
Review comment:
Yes, using a specific logger is more suitable. Thanks for fixing this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix class names in loggers
> --------------------------
>
> Key: DRILL-7530
> URL: https://issues.apache.org/jira/browse/DRILL-7530
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Priority: Major
> Fix For: 1.18.0
>
>
> Some loggers have incorrect class names which leads to incorrect information
> in logs.
> This Jira aims to fix all occurrences of incorrect class names in loggers.
> Preliminary list (some occurrences will be excluded):
> {noformat}
> Name: MapRDBTableCache.java. Expected: MapRDBTableCache. Got:
> MapRDBFormatPlugin.
> Name: HiveFuncHolderExpr.java. Expected: HiveFuncHolderExpr. Got:
> DrillFuncHolderExpr.
> Name: HiveFuncHolder.java. Expected: HiveFuncHolder. Got:
> FunctionImplementationRegistry.
> Name: HiveMetadataProvider.java. Expected: HiveMetadataProvider. Got:
> HiveStats.
> Name: TableEntryCacheLoader.java. Expected: TableEntryCacheLoader. Got:
> TableNameCacheLoader.
> Name: TestKafkaSuit.java. Expected: TestKafkaSuit. Got: LoggerFactory.
> Name: DrillTestWrapper.java. Expected: DrillTestWrapper. Got: BaseTestQuery.
> Name: TestDisabledFunctionality.java. Expected: TestDisabledFunctionality.
> Got: TestExampleQueries.
> Name: TestMergeJoin.java. Expected: TestMergeJoin. Got: HashAggBatch.
> Name: TestLateralJoinCorrectnessBatchProcessing.java. Expected:
> TestLateralJoinCorrectnessBatchProcessing. Got: TestNewLateralJoinCorrectness.
> Name: TestOperatorRecordBatch.java. Expected: TestOperatorRecordBatch. Got:
> SubOperatorTest.
> Name: TestPauseInjection.java. Expected: TestPauseInjection. Got: DummyClass.
> Name: TestComplexTypeWriter.java. Expected: TestComplexTypeWriter. Got:
> TestComplexTypeReader.
> Name: AvgIntervalTypeFunctions.java. Expected: AvgIntervalTypeFunctions. Got:
> AvgFunctions.
> Name: SSLConfigBuilder.java. Expected: SSLConfigBuilder. Got:
> org.apache.drill.exec.ssl.SSLConfigBuilder.
> Name: PlannerPhase.java. Expected: PlannerPhase. Got: DrillRuleSets.
> Name: AbstractIndexDescriptor.java. Expected: AbstractIndexDescriptor. Got:
> AbstractIndexDescriptor .
> Name: CoveringPlanNoFilterGenerator.java. Expected:
> CoveringPlanNoFilterGenerator. Got: CoveringIndexPlanGenerator.
> Name: AbstractSqlSetHandler.java. Expected: AbstractSqlSetHandler. Got:
> AbstractSqlHandler.
> Name: HashJoinMemoryCalculatorImpl.java. Expected:
> HashJoinMemoryCalculatorImpl. Got: BuildSidePartitioning.
> Name: HashJoinMemoryCalculatorImpl.java. Expected:
> HashJoinMemoryCalculatorImpl. Got: PostBuildCalculationsImpl.
> Name: HashJoinMemoryCalculator.java. Expected: HashJoinMemoryCalculator. Got:
> PartitionStatSet.
> Name: NestedLoopJoinTemplate.java. Expected: NestedLoopJoinTemplate. Got:
> NestedLoopJoinBatch.
> Name: PartitionLimitRecordBatch.java. Expected: PartitionLimitRecordBatch.
> Got: LimitRecordBatch.
> Name: HashAggTemplate.java. Expected: HashAggTemplate. Got: HashAggregator.
> Name: SpilledRecordbatch.java. Expected: SpilledRecordbatch. Got:
> SimpleRecordBatch.
> Name: StreamingAggTemplate.java. Expected: StreamingAggTemplate. Got:
> StreamingAggregator.
> Name: SortMemoryManager.java. Expected: SortMemoryManager. Got:
> ExternalSortBatch.
> Name: SortConfig.java. Expected: SortConfig. Got: ExternalSortBatch.
> Name: SortImpl.java. Expected: SortImpl. Got: ExternalSortBatch.
> Name: SingleSenderCreator.java. Expected: SingleSenderCreator. Got:
> SingleSenderRootExec.
> Name: HashTableTemplate.java. Expected: HashTableTemplate. Got: HashTable.
> Name: FrameSupportTemplate.java. Expected: FrameSupportTemplate. Got:
> NoFrameSupportTemplate.
> Name: ScreenCreator.java. Expected: ScreenCreator. Got: ScreenRoot.
> Name: UnionAll.java. Expected: UnionAll. Got: Filter.
> Name: AvgIntervalTypeFunctions.java. Expected: AvgIntervalTypeFunctions. Got:
> AvgFunctions.
> Name: PersistedOptionValue.java. Expected: PersistedOptionValue. Got:
> Deserializer.
> Name: ThreadsResources.java. Expected: ThreadsResources. Got:
> MetricsResources.
> Name: RepeatedVarCharOutput.java. Expected: RepeatedVarCharOutput. Got:
> BaseFieldOutput.
> Name: MockSubScanPOP.java. Expected: MockSubScanPOP. Got: MockGroupScanPOP.
> Name: InMemoryStore.java. Expected: InMemoryStore. Got:
> InMemoryPersistentStore.
> Name: ParquetColumnChunkPageWriteStore.java. Expected:
> ParquetColumnChunkPageWriteStore. Got: ParquetDirectByteBufferAllocator.
> Name: CorrelationTypeFunctions.java. Expected: CorrelationTypeFunctions. Got:
> ${aggrtype.className}Functions.
> Name: MathFunctionTemplates.java. Expected: MathFunctionTemplates. Got:
> ${inputType.className}Functions.
> Name: CastHigh.java. Expected: CastHigh. Got: CastHighFunctions.
> Name: IntervalAggrFunctions2.java. Expected: IntervalAggrFunctions2. Got:
> ${aggrtype.className}Functions.
> Name: SumZeroAggr.java. Expected: SumZeroAggr. Got: SumZeroFunctions.
> Name: NumericFunctionsTemplates.java. Expected: NumericFunctionsTemplates.
> Got: ${numericFunc.className}Functions.
> Name: CovarTypeFunctions.java. Expected: CovarTypeFunctions. Got:
> ${aggrtype.className}Functions.
> Name: AggrTypeFunctions3.java. Expected: AggrTypeFunctions3. Got:
> ${aggrtype.className}Functions.
> Name: AggrBitwiseLogicalTypeFunctions.java. Expected:
> AggrBitwiseLogicalTypeFunctions. Got: ${aggrtype.className}Functions.
> Name: AggrTypeFunctions2.java. Expected: AggrTypeFunctions2. Got:
> ${aggrtype.className}Functions.
> Name: MathFunctions.java. Expected: MathFunctions. Got: GMathFunctions.
> Name: MathFunctions.java. Expected: MathFunctions. Got: ExtendedMathFunctions.
> Name: MathFunctions.java. Expected: MathFunctions. Got: TrigoMathFunctions.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
