[
https://issues.apache.org/jira/browse/DRILL-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020778#comment-17020778
]
ASF GitHub Bot commented on DRILL-7458:
---------------------------------------
paul-rogers commented on pull request #1914: DRILL-7458: Base framework for
storage plugins
URL: https://github.com/apache/drill/pull/1914#discussion_r369346923
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/base/filter/RelOp.java
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.base.filter;
+
+import org.apache.drill.exec.store.base.PlanStringBuilder;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonInclude.Include;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+
+/**
+ * Semanticized form of a Calcite relational operator. Abstracts
+ * out the Drill implementation details to capture just the
+ * column name, operator and value. Supports only expressions
+ * of the form:<br>
+ * <code><column> <relop> <const></code><br>
+ * Where the column is a simple name (not an array or map reference),
+ * the relop is one of a defined set, and the constant is one
+ * of the defined Drill types.
+ * <p>
+ * (The driver will convert expressions of the form:<br>
+ * <code><const></code> <relop> <code><column></code><br>
+ * into the normalized form represented here.
+ */
+
+@JsonInclude(Include.NON_NULL)
+@JsonPropertyOrder({"op", "colName", "value"})
+public class RelOp {
+
+ public enum Op {
+ EQ, NE, LT, LE, GT, GE, IS_NULL, IS_NOT_NULL;
Review comment:
Glad you saw that. Originally, we use constant strings everywhere. And,
since people are not sure the correct strings, I see copy/pasted blocks of name
variations.
The idea here is to say, 1) there is a fixed set of RelOps, and 2) there is
a fixed set of names for those ops.
This is part of the analysis mechanism: take the general-purpose function
call, expression and constant semantics of the query plan and distill it down
to a sharply-defined set of constant expressions for use in filter push-down.
Would actually be handy to define a metadata class for operations that
encapsulates this stuff. At present, that "metadata" is spread across dozens of
classes. Example: default selectivity is embedded somewhere in Calcite. Seems
Calcite has something, (`SqlBinaryOperator`), but it is a bit too abstract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Base storage plugin framework
> -----------------------------
>
> Key: DRILL-7458
> URL: https://issues.apache.org/jira/browse/DRILL-7458
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.18.0
>
>
> The "Easy" framework allows third-parties to add format plugins to Drill with
> moderate effort. (The process could be easier, but "Easy" makes it as simple
> as possible given the current structure.)
> At present, no such "starter" framework exists for storage plugins. Further,
> multiple storage plugins have implemented filter push down, seemingly by
> copying large blocks of code.
> This ticket offers a "base" framework for storage plugins and for filter
> push-downs. The framework builds on the EVF, allowing plugins to also support
> project push down.
> The framework has a "test mule" storage plugin to verify functionality, and
> was used as the basis of an REST-like plugin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
