[
https://issues.apache.org/jira/browse/DRILL-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020890#comment-17020890
]
ASF GitHub Bot commented on DRILL-7458:
---------------------------------------
arina-ielchiieva commented on pull request #1914: DRILL-7458: Base framework
for storage plugins
URL: https://github.com/apache/drill/pull/1914#discussion_r369428346
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/base/DummyGroupScan.java
##########
@@ -97,36 +100,33 @@ public RelOp acceptFilter(RelOp relOp) {
// Pretend that "id" is a special integer column. Can handle
// equality only.
-
if (relOp.colName.contentEquals("id")) {
// To allow easier testing, require exact type match: no
// attempt at type conversion here.
-
if (relOp.op != RelOp.Op.EQ || relOp.value.type != MinorType.INT) {
return null;
}
return relOp;
}
- // All other columns apply only if projected
-
- if (!FILTER_COLS.contains(relOp.colName)) {
+ // "allTypes" table filters everything. All other tables
+ // only project a fixed set of columns. Simulates a plugin
+ // which can project only some columns.
+ if (!scanSpec.tableName.equals("allTypes") &&
!FILTER_COLS.contains(relOp.colName)) {
Review comment:
Nit: usually constant goes first to avoid NPE `"allTypes".equals(...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Base storage plugin framework
> -----------------------------
>
> Key: DRILL-7458
> URL: https://issues.apache.org/jira/browse/DRILL-7458
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.18.0
>
>
> The "Easy" framework allows third-parties to add format plugins to Drill with
> moderate effort. (The process could be easier, but "Easy" makes it as simple
> as possible given the current structure.)
> At present, no such "starter" framework exists for storage plugins. Further,
> multiple storage plugins have implemented filter push down, seemingly by
> copying large blocks of code.
> This ticket offers a "base" framework for storage plugins and for filter
> push-downs. The framework builds on the EVF, allowing plugins to also support
> project push down.
> The framework has a "test mule" storage plugin to verify functionality, and
> was used as the basis of an REST-like plugin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
