[
https://issues.apache.org/jira/browse/DRILL-7554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024060#comment-17024060
]
ASF GitHub Bot commented on DRILL-7554:
---------------------------------------
cgivre commented on pull request #1962: DRILL-7554: Convert LTSV Format Plugin
to EVF
URL: https://github.com/apache/drill/pull/1962
# [DRILL-7554](https://issues.apache.org/jira/browse/DRILL-7554): Convert
LTSV Format Plugin to EVF
## Description
This PR converts the existing LTSV Format Plugin to EVF. This PR also
changes the traditional format of format plugins. Instead of having a minimum
of three files, the `XXXFormatPlugin`, `XXXFormatPluginConfig`, and
`XXXFormatBatchReader`, this plugin introduces a new abstract class:
`EasyEVFBatchReader` which the `XXXBatchReader` extends.
Instead of implementing a BatchReader, the proposed pattern is that for new
format plugins, most of the code which is frequently duplicated in every format
plugin, new format plugins can be created simply by extending the
`EasyEVFBatchReader` class and implementing a regular iterator to read through
the data and perform the column mappings.
This PR is the first in a series of format plugin conversions to EVF, so the
`EasyEVFBatchReader` should not be considered a final work, but the basis for a
cleaner API for format plugins. I still need to add schema definition methods,
but will do so with format plugins with known schemata.
## Documentation
No user-visible changes. LTSV is already documented in both `README.md` and
the Drill web site.
## Testing
As a part of this PR, I updated all unit tests to use the RowSet framework.
I also added unit tests for:
- Serialization/Deserialization
- Compressed Files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Convert LTSV Format Plugin to EVF
> ---------------------------------
>
> Key: DRILL-7554
> URL: https://issues.apache.org/jira/browse/DRILL-7554
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Text & CSV
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.18.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
