[
https://issues.apache.org/jira/browse/DRILL-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035303#comment-17035303
]
ASF GitHub Bot commented on DRILL-7572:
---------------------------------------
vvysotskyi commented on pull request #1971: DRILL-7572: JSON structure parser
URL: https://github.com/apache/drill/pull/1971#discussion_r376361296
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ArrayListener.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.easy.json.parser;
+
+/**
+ * Represents one level within an array. The first time the parser sees
+ * the array element, it will call one of the "Element" methods with the
+ * look-ahead values visible to the parser. Since JSON is flexible, later
+ * data shapes may not necessarily follow the first shape. The implementation
+ * must handle this or throw an error if not supported.
+ * <p>
+ * When creating a multi-dimensional array, each array level is built one
+ * by one. each will receive the same type information (decreased by one
+ * array level.)
+ * <p>
+ * Then, while parsing, the parser calls events on the start and end of the
+ * array, as well as on each element.
+ * <p>
+ * The array listener is an attribute of a value listener, represent the
+ * "arrayness" of that value, if the value allows an array.
+ */
+public interface ArrayListener {
+
+ void onStart();
Review comment:
Could you please add javadocs for these methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JSON structure parser
> ---------------------
>
> Key: DRILL-7572
> URL: https://issues.apache.org/jira/browse/DRILL-7572
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.18.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> DRILL-6953, PR #1913 provides an EVF-version of the JSON reader. The original
> plan was to commit a first draft, with the feature disabled, then evolve from
> there. Review comments suggested we ensure that the first PR pass all unit
> tests with the feature enabled. Another comment suggested the JSON parser
> portion be reusable for other format or storage plugins. All good ideas.
> The amount of change in the original PR was becoming too large. So, we'll go
> ahead and split the work into smaller portions.
> This ticket is for the "JSON structure parser." This parser accepts the token
> stream from the Jackson parser and provides a framework to create a tree
> structure that describes the data. To keep the code simple, to simplify
> tests, and to make review easier, the structure parser does not directly
> integrate with the rest of Drill. Instead, it provides a number of listener
> interfaces which the next level implements. (The next level will be in
> another PR.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
