[
https://issues.apache.org/jira/browse/DRILL-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036114#comment-17036114
]
ASF GitHub Bot commented on DRILL-7574:
---------------------------------------
KazydubB commented on pull request #1974: DRILL-7574: Generalize the projection
parser
URL: https://github.com/apache/drill/pull/1974#discussion_r377038532
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/RowSetTestUtils.java
##########
@@ -58,6 +58,10 @@ private RowSetTestUtils() { }
new SchemaPath[] {SchemaPath.STAR_COLUMN});
}
+ public static List<SchemaPath> projectNone() {
+ return new ArrayList<>();
Review comment:
Is it safe to return unmodifiable instance, such as
`Collections.emptyList()` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Generalize projection parser
> ----------------------------
>
> Key: DRILL-7574
> URL: https://issues.apache.org/jira/browse/DRILL-7574
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> EVF contains a bit of code called the"projection parser": it takes a
> projection list and converts it into a form useful for scan projection. The
> prior version handled single-level arrays, such as needed for the
> {{`columns`}} column in the text reader. For JSON, we must handle arbitrary
> column structures such as:
> {noformat}
> a, a.b, a[1], a[1][2], a.[1][2].b
> {noformat}
> Adding the DICT type means that we must be a bit more general in the parser.
> This ticket fixes these issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
