[
https://issues.apache.org/jira/browse/DRILL-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043490#comment-17043490
]
ASF GitHub Bot commented on DRILL-7596:
---------------------------------------
cgivre commented on pull request #1992: DRILL-7596: drill-format-esri module
Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383257998
##########
File path: contrib/format-esri/pom.xml
##########
@@ -18,7 +18,8 @@
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
Review comment:
Reverted first line spacing. Just as a side note, I ran Drill's code
formatting macro in Intellij which did this. We might want to think about
updating that so that this line is formatted correctly in future PRs, but that
is out of scope for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> drill-format-esri module uses 1.16.0 version of
> org.apache.drill.contrib:drill-udfs
> -----------------------------------------------------------------------------------
>
> Key: DRILL-7596
> URL: https://issues.apache.org/jira/browse/DRILL-7596
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Vova Vysotskyi
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.18.0
>
>
> pom file for {{drill-format-esri}} module has the following dependency:
> {code:xml}
> <dependency>
> <groupId>org.apache.drill.contrib</groupId>
> <artifactId>drill-udfs</artifactId>
> <version>1.16.0</version>
> </dependency>
> {code}
> with hardcoded Drill version instead of using ${project.version}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
