[ 
https://issues.apache.org/jira/browse/DRILL-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044498#comment-17044498
 ] 

ASF GitHub Bot commented on DRILL-7578:
---------------------------------------

arina-ielchiieva commented on pull request #1978: DRILL-7578: HDF5 Metadata 
Queries Fail with Large Files
URL: https://github.com/apache/drill/pull/1978#discussion_r383908163
 
 

 ##########
 File path: 
contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java
 ##########
 @@ -458,7 +494,7 @@ private void projectMetadataRow(RowSetLoader rowWriter) {
 
   /**
    * This function writes one row of data in a metadata query. The number of 
dimensions here is n+1. So if the actual dataset is a 1D column, it will be 
written as a list.
-   * This is function is only called in metadata queries as the schema is not 
known in advance.
+   * This is function is only called in metadata queries as the schema is not 
known in advance.  If the datasize is greater than 16MB, the function does not 
project the dataset
 
 Review comment:
   ```suggestion
      * This is function is only called in metadata queries as the schema is 
not known in advance. If the datasize is greater than 16MB, the function does 
not project the dataset
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HDF5 Metadata Queries Fail with Large Files
> -------------------------------------------
>
>                 Key: DRILL-7578
>                 URL: https://issues.apache.org/jira/browse/DRILL-7578
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.18.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.18.0
>
>
> With large files, Drill runs out of memory when attempting to project large 
> datasets in the metadata.  
> This PR adds a configuration option which removes the dataset projection from 
> metadata queries and fixes this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to