[
https://issues.apache.org/jira/browse/DRILL-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045809#comment-17045809
]
ASF GitHub Bot commented on DRILL-7582:
---------------------------------------
vvysotskyi commented on pull request #1999: DRILL-7582: Moved Drillbits REST
API communication to the back end layer
URL: https://github.com/apache/drill/pull/1999#discussion_r384687532
##########
File path: exec/java-exec/src/main/resources/rest/index.ftl
##########
@@ -350,17 +340,17 @@
currentRow.find("#shutdown").prop('disabled',true).css('opacity',0.5).css('cursor','not-allowed');
currentRow.find("#queriesCount").text("");
} else {
- if (status_map[key] == "ONLINE") {
+ if (status_map[key] === "ONLINE") {
currentRow.find("#status").text(status_map[key]).css('font-style','').prop('title','');
- //EnableShutdown IFF => !isAuthEnabled-&&-!HTTPS OR
isAuthEnabled-&&-current
- if ( ( !${model.isAuthEnabled()?c} && location.protocol !=
"https:" ) || ( ${model.shouldShowAdminInfo()?c} &&
currentRow.find("#current").html() == "Current" ) ) {
+ //EnableShutdown IFF => !isAuthEnabled OR
isAuthEnabled-&&-current
+ if ( ( !${model.isAuthEnabled()?c} ) || (
${model.shouldShowAdminInfo()?c} && currentRow.find("#current").html() ===
"Current" ) ) {
currentRow.find("#shutdown").prop('disabled',false).css('opacity',1.0).css('cursor','pointer').attr('title','');
}
} else {
- if (currentRow.find("#current").html() == "Current") {
+ if (currentRow.find("#current").html() === "Current") {
fillQueryCount(i);
}
-
currentRow.find("#status").text(status_map[key]).css('font-style','').prop('title','');;
+
currentRow.find("#status").text(status_map[key]).css('font-style',
'').prop('title', '');
Review comment:
Something bad with indentation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drill docker Web UI doesn't show resources usage information if map the
> container to a non-default port
> -------------------------------------------------------------------------------------------------------
>
> Key: DRILL-7582
> URL: https://issues.apache.org/jira/browse/DRILL-7582
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Anton Gozhiy
> Assignee: Anton Gozhiy
> Priority: Major
> Fix For: 1.18.0
>
>
> *Steps:*
> # Run Drill docker container with non-default port published:
> {noformat}
> $ docker container run -it --rm -p 9047:8047 apache/drill
> {noformat}
> # Open Drill Web UI (localhost:9047)
> *Expected result:*
> The following fields should contain relevant information:
> * Heap Memory Usage
> * Direct Memory Usage
> * CPU Usage
> * Avg Sys Load
> * Uptime
> *Actual result:*
> "Not Available" is displayed.
> *Note:* if publish the default port (-p 8047:8047), everything is showed
> correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
