[
https://issues.apache.org/jira/browse/DRILL-7604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045831#comment-17045831
]
ASF GitHub Bot commented on DRILL-7604:
---------------------------------------
dobesv commented on pull request #1997: DRILL-7604: Allow session options to be
set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384709874
##########
File path: exec/java-exec/src/main/resources/rest/query/query.ftl
##########
@@ -83,6 +83,16 @@
Submit
</button>
<input type="checkbox" name="forceLimit" value="limit" <#if
model.isAutoLimitEnabled()>checked</#if>> Limit results to <input type="text"
id="autoLimit" name="autoLimit" min="0"
value="${model.getDefaultRowsAutoLimited()?c}" size="6" pattern="[0-9]*"> rows
<span class="glyphicon glyphicon-info-sign" title="Limits the number of records
retrieved in the query. Ignored if query has a limit already"
style="cursor:pointer"></span>
+ <label> Store Format
Review comment:
This should work for 99% of users, I think. If they select something that
isn't supported they will just get an error. The alternative would be a
free-form text input, which would still just report an error if you input an
unsupported value. This drop-down can be updated over time to include all
known supported output formats of all the plugins and the user can more easily
pick a format using a drop-down than a text input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cannot set session options using REST API / Web UI
> --------------------------------------------------
>
> Key: DRILL-7604
> URL: https://issues.apache.org/jira/browse/DRILL-7604
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.17.0
> Reporter: Dobes Vandermeer
> Assignee: Dobes Vandermeer
> Priority: Minor
>
> Some commands are configured using session options that you set using the
> `SET` command. However, the `SET` command is not useful in the Web UI and
> REST API because the options you set are not preserved in the next request.
> For example, when using CREATE TABLE AS you must `SET store.format csv` to
> set the output format to comma-separated value, but this is not possible via
> the REST API.
> I propose that the API be updated to support options that are normally
> provided using SET:
> # The JSON API accepts an object "options" whose keys are options and values
> are option values. The values should have an appropriate type for the given
> option, e.g. JSON boolean if the option type is boolean
> # The form-based API used by the Web UI scans any provided form fields that
> match a valid session option and sets those options, parsing strings
> according to the type of option
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
