[
https://issues.apache.org/jira/browse/DRILL-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Rogers updated DRILL-7612:
-------------------------------
Description:
See note in the {{ExcelFormatConfig}} class. The class is designed with mutable
fields. However, if any of the fields are actually changed while the excel
reader pluguin is active, the result is undefined. This is true, by the way,
for all storage and plugin configs.
Would be better for the class to be immutable with {{final}} fields. By doing
this it becomes impossible for uninformed code to grab a config from the plugin
registry, modify it, and put it back, causing the registry to become confused
due to its value-based config map.
was:
See note in the {{ExcelFormatConfig}} class. The class is designed with mutable
fields. However, if any of the fields are actually changed while the excel
reader is active, the result is undefined.
Would be better for the class to be immutable with {{final}} fields.
> Modify the ExcelFormatConfig immutable
> --------------------------------------
>
> Key: DRILL-7612
> URL: https://issues.apache.org/jira/browse/DRILL-7612
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Priority: Major
>
> See note in the {{ExcelFormatConfig}} class. The class is designed with
> mutable fields. However, if any of the fields are actually changed while the
> excel reader pluguin is active, the result is undefined. This is true, by the
> way, for all storage and plugin configs.
> Would be better for the class to be immutable with {{final}} fields. By doing
> this it becomes impossible for uninformed code to grab a config from the
> plugin registry, modify it, and put it back, causing the registry to become
> confused due to its value-based config map.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
