[
https://issues.apache.org/jira/browse/DRILL-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046275#comment-17046275
]
ASF GitHub Bot commented on DRILL-7590:
---------------------------------------
paul-rogers commented on pull request #1988: DRILL-7590: Refactor plugin
registry
URL: https://github.com/apache/drill/pull/1988#discussion_r384890642
##########
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##########
@@ -65,6 +65,7 @@ public static void setup() throws Exception {
ExcelFormatConfig formatConfig = new ExcelFormatConfig();
cluster.defineFormat("cp", "excel", formatConfig);
+ cluster.defineFormat("dfs", "excel", formatConfig);
Review comment:
The tests failed without it. Don't know why. I suspect this is a result of
being more strict about not mucking with configs after they are stored in the
plugin registry. That is, the prior behavior was wrong, but benign. This change
is "more right."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor plugin registry
> ------------------------
>
> Key: DRILL-7590
> URL: https://issues.apache.org/jira/browse/DRILL-7590
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The plugin registry connects configurations, stored in ZK, with
> implementations, which are Java classes. The registry handles a large number
> of tasks including:
> * Populating "bootstrap" plugin configurations and handling upgrades.
> * Reading from, and writing to, the persistent store in ZK.
> * Handling "normal" (configured) plugins and special system plugins (which
> have no configuration.)
> * Handle format plugins which are always associated with the DFS storage
> plugin.
> * And so on.
> The code has grown overly complex. As we look to add a new, cleaner plugin
> mechanism, we will start by cleaning up what we have to allow the new
> mechanism to be one of many.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
