[
https://issues.apache.org/jira/browse/DRILL-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047629#comment-17047629
]
ASF GitHub Bot commented on DRILL-7203:
---------------------------------------
arina-ielchiieva commented on pull request #1994: DRILL-7203: Accept
impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385699746
##########
File path: exec/java-exec/src/main/resources/rest/query/query.ftl
##########
@@ -43,15 +43,13 @@
<#include "*/runningQuery.ftl">
- <#if model.isOnlyImpersonationEnabled()>
- <div class="form-group">
- <label for="userName">User Name</label>
- <input type="text" size="30" name="userName" id="userName"
placeholder="User Name">
- </div>
- </#if>
-
<form role="form" id="queryForm" action="/query" method="POST">
+ <#if model.isOnlyImpersonationEnabled()>
<div class="form-group">
+ <label for="userName">UserName</label>
Review comment:
Please add space between words as before.
```suggestion
<label for="userName">User Name</label>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Back button for failed query does not return on Query page
> -----------------------------------------------------------
>
> Key: DRILL-7203
> URL: https://issues.apache.org/jira/browse/DRILL-7203
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Arina Ielchiieva
> Assignee: Dobes Vandermeer
> Priority: Major
> Attachments: back_button.JPG
>
>
> Back button for failed query returns on previous page before Query page but
> not on the Query page.
> Steps:
> 1. go to Logs page
> 2. go to Query page
> 3. execute query with incorrect syntax (ex: xxxxx)
> 4. error message will be displayed, Back button will be in left corner
> (screenshot attached)
> 5. press Back button
> 6. user is redirected to Logs page
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
