[
https://issues.apache.org/jira/browse/DRILL-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049191#comment-17049191
]
ASF GitHub Bot commented on DRILL-7592:
---------------------------------------
vvysotskyi commented on pull request #1989: DRILL-7592: Add missing licenses
and update plugins exclusion list
URL: https://github.com/apache/drill/pull/1989#discussion_r386377713
##########
File path: common/src/main/resources/drill-module.conf
##########
@@ -1,18 +1,20 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http:// www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
// This file tells Drill to consider this module when class path scanning.
// This file can also include any supplementary configuration information.
Review comment:
Thanks, fixed all the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add missing licenses and update plugins exclusion list
> ------------------------------------------------------
>
> Key: DRILL-7592
> URL: https://issues.apache.org/jira/browse/DRILL-7592
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: 1.18.0
>
>
> The project contains a lot of files without licenses, like this one:
> [https://github.com/apache/drill/blob/f2654eed3b6d444280b5c0c2a507edc355c676e6/contrib/format-excel/src/main/resources/drill-module.conf].
> Besides {{*.conf}} files, there are other file types that may and should
> contain license.
> Except for adding licenses, some binary files should be excluded from the
> check to avoid warnings like this one:
> {noformat}
> [INFO] --- license-maven-plugin:3.0:check (default) @ drill-root ---
> [INFO] Checking licenses...
> [WARNING] Unknown file extension:
> /home/runner/work/drill/drill/contrib/format-esri/src/test/resources/shapefiles/CA-cities.shp
> [WARNING] Unknown file extension:
> /home/runner/work/drill/drill/contrib/format-esri/src/test/resources/shapefiles/CA-cities.prj
> [WARNING] Unknown file extension:
> /home/runner/work/drill/drill/contrib/format-esri/src/test/resources/shapefiles/CA-cities.dbf
> [WARNING] Unknown file extension:
> /home/runner/work/drill/drill/contrib/storage-hive/core/src/test/resources/complex_types/map/map_union_tbl.avro
> [WARNING] Unknown file extension:
> /home/runner/work/drill/drill/exec/java-exec/src/test/resources/avro/map_string_to_long.avro
> [WARNING] Unknown file extension:
> /home/runner/work/drill/drill/exec/java-exec/src/test/resources/regex/firewall.ssdlog
> [WARNING] Unable to find a comment style definition for some files. You may
> want to add a custom mapping for the relevant file extensions.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
