[ 
https://issues.apache.org/jira/browse/DRILL-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049860#comment-17049860
 ] 

ASF GitHub Bot commented on DRILL-7615:
---------------------------------------

paul-rogers commented on pull request #2006: DRILL-7615: UNION ALL query 
returns the wrong result for the decimal value
URL: https://github.com/apache/drill/pull/2006#discussion_r386776273
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/types/Types.java
 ##########
 @@ -131,6 +132,17 @@ public static boolean isIntervalType(MinorType type) {
     }
   }
 
+  /**
+   * Returns true if all specified types are decimal data types.
+   *
+   * @param types types to check
+   * @return true if all specified types are decimal data type.
+   */
+  public static boolean areDecimalTypes(MajorType... types) {
 
 Review comment:
   General enough to define as a method? Seems we'd end up having similar 
methods for many predicates.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> UNION ALL query returns the wrong result for the decimal value
> --------------------------------------------------------------
>
>                 Key: DRILL-7615
>                 URL: https://issues.apache.org/jira/browse/DRILL-7615
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.14.0
>            Reporter: Vova Vysotskyi
>            Assignee: Vova Vysotskyi
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.18.0
>
>
> The following query:
> {code:java}
> select cast(1000 as decimal(10,1)) 
> union all 
> select 596.000 
> {code}
> returns incorrect result:
> {code:java}
> 10.000
> 596.000
> {code}
> The expected result is 1000.000 for the first record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to