[
https://issues.apache.org/jira/browse/DRILL-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051907#comment-17051907
]
ASF GitHub Bot commented on DRILL-7620:
---------------------------------------
arina-ielchiieva commented on pull request #2010: DRILL-7620: Fix plugin
mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r388149815
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java
##########
@@ -145,16 +216,42 @@ void putFormatPlugin(String pluginName, String
formatName,
* @param formatConfig
* The format config for the associated FormatPlugin
* @return A FormatPlugin instance
- * @throws ExecutionSetupException
+ * @throws PluginException
* if plugin cannot be obtained
*/
FormatPlugin getFormatPlugin(StoragePluginConfig storageConfig,
- FormatPluginConfig formatConfig) throws ExecutionSetupException;
+ FormatPluginConfig formatConfig) throws PluginException;
/**
* Get the Schema factory associated with this storage plugin registry.
*
* @return A SchemaFactory that can register the schemas associated with
this plugin registry.
*/
SchemaFactory getSchemaFactory();
+
+ /**
+ * Object mapper to read/write the JSON form of a plugin
+ * config.
+ * @return
Review comment:
Add description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Storage plugin update page shows that a plugin is disabled though it is
> actually enabled.
> -----------------------------------------------------------------------------------------
>
> Key: DRILL-7620
> URL: https://issues.apache.org/jira/browse/DRILL-7620
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.18.0
> Reporter: Anton Gozhiy
> Assignee: Paul Rogers
> Priority: Blocker
> Fix For: 1.18.0
>
>
> *Steps to reproduce:*
> # On Web UI, open storage page
> # Disable some plugin (e.g. "cp")
> # Enable this plugin (It is displayed in "enabled" section now)
> # Update the plugin, look at the "enabled" property
> *Expected result:*
> "enabled": true
> *Actual result:*
> "enabled": false
> *Note:* Though it is displayed as disabled in the config, queries to it are
> working.
> *Workaround:* Enable it again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
