[
https://issues.apache.org/jira/browse/DRILL-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053581#comment-17053581
]
ASF GitHub Bot commented on DRILL-7620:
---------------------------------------
agozhiy commented on issue #2010: DRILL-7620: Fix plugin mutability issues
URL: https://github.com/apache/drill/pull/2010#issuecomment-595855023
@paul-rogers, I tested your recent changes to this PR and found some issues:
I used drill-embedded with previously wiped plugins (rm -rf
/tmp/drill/sys.storage_plugins) to make them default.
Then:
1. Updated hive plugin to make it incorrect and enable it:
```json
{
"type": "hive",
"configProps": {
"hive.metastore.sasl.enabled": "false"
},
"enabled": true
}
```
2. Tried to run a query with cp plugin:
```sql
SELECT * FROM cp.`employee.json` LIMIT 20
```
3. It worked, but a hive-related exception appeared in the logs (in case of
embedded Drill it is being written directly to out)
4. Disabled the incorrect plugin and repeat the query to cp.
5. Observed that the exception happened again in spite of disabled hive
plugin
Also once my query to cp hanged with the above exception looped, though I
wasn't able to reproduce this again.
I think, maybe it's better to return to the old behavior, when the it wasn't
possible to enable plugin with incorrect config? And then fix it more
thoroughly in a separate commit...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Storage plugin update page shows that a plugin is disabled though it is
> actually enabled.
> -----------------------------------------------------------------------------------------
>
> Key: DRILL-7620
> URL: https://issues.apache.org/jira/browse/DRILL-7620
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.18.0
> Reporter: Anton Gozhiy
> Assignee: Paul Rogers
> Priority: Blocker
> Fix For: 1.18.0
>
>
> *Steps to reproduce:*
> # On Web UI, open storage page
> # Disable some plugin (e.g. "cp")
> # Enable this plugin (It is displayed in "enabled" section now)
> # Update the plugin, look at the "enabled" property
> *Expected result:*
> "enabled": true
> *Actual result:*
> "enabled": false
> *Note:* Though it is displayed as disabled in the config, queries to it are
> working.
> *Workaround:* Enable it again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
