[
https://issues.apache.org/jira/browse/DRILL-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057706#comment-17057706
]
ASF GitHub Bot commented on DRILL-7620:
---------------------------------------
arina-ielchiieva commented on pull request #2010: DRILL-7620: Fix plugin
mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r391469634
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
##########
@@ -233,6 +233,17 @@ private void loadIntrinsicPlugins() throws
PluginException {
continue;
}
for (StoragePlugin sysPlugin : intrinsicPlugins) {
+ // Enforce lower case names. Since the name of a system plugin
+ // is "hard coded", we can't adjust it if it is not already
+ // lower case. All we can do is fail to tell the developer that
+ // something is wrong.
+ String origName = sysPlugin.getName();
+ String lcName = sysPlugin.getName().toLowerCase();
+ if (!origName.equals(lcName)) {
+ throw new IllegalStateException(String.format(
+ "Plugin names must be lower case. System plugin name is not
lower case: %s",
Review comment:
```suggestion
"Plugin names must be in lower case. System plugin name is not
lower case: %s",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Storage plugin update page shows that a plugin is disabled though it is
> actually enabled.
> -----------------------------------------------------------------------------------------
>
> Key: DRILL-7620
> URL: https://issues.apache.org/jira/browse/DRILL-7620
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.18.0
> Reporter: Anton Gozhiy
> Assignee: Paul Rogers
> Priority: Blocker
> Fix For: 1.18.0
>
>
> *Steps to reproduce:*
> # On Web UI, open storage page
> # Disable some plugin (e.g. "cp")
> # Enable this plugin (It is displayed in "enabled" section now)
> # Update the plugin, look at the "enabled" property
> *Expected result:*
> "enabled": true
> *Actual result:*
> "enabled": false
> *Note:* Though it is displayed as disabled in the config, queries to it are
> working.
> *Workaround:* Enable it again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
