[
https://issues.apache.org/jira/browse/DRILL-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059213#comment-17059213
]
ASF GitHub Bot commented on DRILL-5956:
---------------------------------------
paul-rogers commented on pull request #1888: DRILL-5956: Add Storage Plugin for
Apache Druid
URL: https://github.com/apache/drill/pull/1888#discussion_r352262866
##########
File path:
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/DruidGroupScan.java
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.druid;
+
+import com.fasterxml.jackson.annotation.JacksonInject;
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+
+import org.apache.drill.common.exceptions.ExecutionSetupException;
+import org.apache.drill.common.expression.SchemaPath;
+import org.apache.drill.exec.physical.EndpointAffinity;
+import org.apache.drill.exec.physical.base.AbstractGroupScan;
+import org.apache.drill.exec.physical.base.GroupScan;
+import org.apache.drill.exec.physical.base.PhysicalOperator;
+import org.apache.drill.exec.physical.base.ScanStats;
+import org.apache.drill.exec.proto.CoordinationProtos;
+import org.apache.drill.exec.store.StoragePluginRegistry;
+
+import org.apache.drill.exec.store.schedule.AffinityCreator;
+import org.apache.drill.exec.store.schedule.AssignmentCreator;
+import org.apache.drill.exec.store.schedule.CompleteWork;
+import org.apache.drill.exec.store.schedule.EndpointByteMap;
+import org.apache.drill.exec.store.schedule.EndpointByteMapImpl;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
+import org.apache.drill.shaded.guava.com.google.common.collect.ListMultimap;
+import org.apache.drill.shaded.guava.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+
+@JsonTypeName("druid-scan")
+public class DruidGroupScan extends AbstractGroupScan {
+
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DruidGroupScan.class);
+ private static final long DEFAULT_TABLET_SIZE = 1000;
+
+ private DruidStoragePluginConfig storagePluginConfig;
Review comment:
All fields should be `final` to show that they should not be changed (except
for transient caches). This makes clear that to make a change, we must make a
copy. Calcite will hold multiple copies and compare the costs of the several
choices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Storage Plugin for Apache Druid
> -----------------------------------
>
> Key: DRILL-5956
> URL: https://issues.apache.org/jira/browse/DRILL-5956
> Project: Apache Drill
> Issue Type: Wish
> Components: Storage - Other
> Reporter: Jiaqi Liu
> Priority: Major
> Labels: Enhancement, Storage-Plugin
> Fix For: 1.18.0
>
>
> As more and more companies are using Druid for mission-critical industrial
> products, Drill could gain much more popularity with Druid as one of its
> supported storage plugin so that uses could easily bind Druid cluster to
> running Drill instance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
