[
https://issues.apache.org/jira/browse/DRILL-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059214#comment-17059214
]
ASF GitHub Bot commented on DRILL-5956:
---------------------------------------
paul-rogers commented on pull request #1888: DRILL-5956: Add Storage Plugin for
Apache Druid
URL: https://github.com/apache/drill/pull/1888#discussion_r352263247
##########
File path:
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/DruidScanSpecBuilder.java
##########
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.druid;
+
+import org.apache.drill.common.expression.SchemaPath;
+import org.apache.drill.exec.store.druid.common.DruidBoundFilter;
+import org.apache.drill.exec.store.druid.common.DruidIntervalFilter;
+import org.apache.drill.exec.store.druid.common.DruidNotFilter;
+import org.apache.drill.exec.store.druid.common.DruidRegexFilter;
+import org.apache.drill.exec.store.druid.common.DruidSearchFilter;
+import org.apache.drill.exec.store.druid.common.DruidSelectorFilter;
+import org.apache.drill.exec.store.druid.druid.SelectQuery;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+class DruidScanSpecBuilder {
+
+ private static final Logger logger =
LoggerFactory.getLogger(DruidScanSpecBuilder.class);
+
+ private static final String REGEX_KEYWORD_HINT = "$regex$_";
+
+ DruidScanSpec build(String dataSourceName,
+ String functionName,
+ SchemaPath field,
+ Object fieldValue) throws IOException {
+ // extract the field name
+
+ String fieldName = field.getAsNamePart().getName();
//.getAsUnescapedPath();
+ String filter;
+
+ logger.debug("createDruidScanSpec called. FunctionName - "
+ + functionName + ", field - " + fieldName + ", fieldValue - "
+ fieldValue);
+
+ switch (functionName) {
+ case "equal":
+ {
+ if
(fieldName.equalsIgnoreCase(SelectQuery.IntervalDimensionName)) {
+ DruidIntervalFilter druidIntervalFilter = new
DruidIntervalFilter((String)fieldValue);
+ filter = druidIntervalFilter.toJson();
+ break;
+ } else {
+ DruidSelectorFilter druidSelectorFilter = new
DruidSelectorFilter(fieldName, (String) fieldValue);
+ filter = druidSelectorFilter.toJson();
+ break;
+ }
+ }
+ case "not_equal":
+ {
+ DruidSelectorFilter druidSelectorFilter = new
DruidSelectorFilter(fieldName, String.valueOf(fieldValue));
+ String selectorFilter = druidSelectorFilter.toJson();
+ DruidNotFilter druidNotFilter = new
DruidNotFilter(selectorFilter);
+ filter = druidNotFilter.toJson();
+ break;
+ }
+ case "greater_than_or_equal_to":
+ {
+ DruidBoundFilter druidBoundFilter = new
DruidBoundFilter(fieldName, String.valueOf(fieldValue), null);
+ filter = druidBoundFilter.toJson();
+ break;
+ }
+ case "greater_than":
+ {
+ DruidBoundFilter druidBoundFilter = new
DruidBoundFilter(fieldName, String.valueOf(fieldValue), null);
+ druidBoundFilter.setLowerStrict(true);
+ filter = druidBoundFilter.toJson();
+ break;
+ }
+ case "less_than_or_equal_to":
+ {
+ DruidBoundFilter druidBoundFilter = new
DruidBoundFilter(fieldName, null, String.valueOf(fieldValue));
+ filter = druidBoundFilter.toJson();
+ break;
+ }
+ case "less_than":
+ {
+ DruidBoundFilter druidBoundFilter = new
DruidBoundFilter(fieldName, null, String.valueOf(fieldValue));
+ druidBoundFilter.setUpperStrict(true);
+ filter = druidBoundFilter.toJson();
+ break;
+ }
+ case "isnull":
Review comment:
As it turns out, only one of these is actually used. We have lots of
copy/paste that has preserved the fact that someone did not know the correct
form. An upcoming PR will declare these names as constants in the related
physical operator nodes to avoid this ongoing confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Storage Plugin for Apache Druid
> -----------------------------------
>
> Key: DRILL-5956
> URL: https://issues.apache.org/jira/browse/DRILL-5956
> Project: Apache Drill
> Issue Type: Wish
> Components: Storage - Other
> Reporter: Jiaqi Liu
> Priority: Major
> Labels: Enhancement, Storage-Plugin
> Fix For: 1.18.0
>
>
> As more and more companies are using Druid for mission-critical industrial
> products, Drill could gain much more popularity with Druid as one of its
> supported storage plugin so that uses could easily bind Druid cluster to
> running Drill instance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
