[
https://issues.apache.org/jira/browse/DRILL-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059457#comment-17059457
]
ASF GitHub Bot commented on DRILL-7330:
---------------------------------------
paul-rogers commented on pull request #2026: DRILL-7330: Implement metadata
usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392608554
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/ImplicitColumnManager.java
##########
@@ -81,40 +83,36 @@
protected boolean useLegacyWildcardExpansion = true;
/**
- * Specify the selection root for a directory scan, if any.
- * Used to populate partition columns. Also, specify the maximum
- * partition depth.
- *
- * @param rootPath Hadoop file path for the directory
- * @param partitionDepth maximum partition depth across all files
- * within this logical scan operator (files in this scan may be
- * shallower)
- */
-
- public void setSelectionRoot(Path rootPath) {
- this.rootDir = rootPath;
- }
-
- public void setPartitionDepth(int partitionDepth) {
- this.partitionCount = partitionDepth;
- }
-
- public void setFiles(List<Path> files) {
+ * Specify the selection root for a directory scan, if any.
+ * Used to populate partition columns. Also, specify the maximum
+ * partition depth.
+ *
+ * @param rootPath Hadoop file path for the directory
+ */
+ public void setSelectionRoot(Path rootPath) {
+ this.rootDir = rootPath;
+ }
+
+ public void setPartitionDepth(int partitionDepth) {
+ this.partitionCount = partitionDepth;
+ }
+
+ public void setFiles(List<Path> files) {
this.files = files;
}
- /**
- * Indicates whether to expand partition columns when the query contains
a wildcard.
- * Supports queries such as the following:<code><pre>
- * select * from dfs.`partitioned-dir`</pre></code>
- * In which the output columns will be (columns, dir0) if the partitioned
directory
- * has one level of nesting.
- *
- * See {@link TestImplicitFileColumns#testImplicitColumns}
- */
- public void useLegacyWildcardExpansion(boolean flag) {
- useLegacyWildcardExpansion = flag;
- }
+ /**
+ * Indicates whether to expand partition columns when the query contains a
wildcard.
+ * Supports queries such as the following:<code><pre>
+ * select * from dfs.`partitioned-dir`</pre></code>
+ * In which the output columns will be (columns, dir0) if the partitioned
directory
+ * has one level of nesting.
+ * <p>
+ * See {@code TestImplicitFileColumns#testImplicitColumns}
Review comment:
Maybe `@see`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement metadata usage for text format plugin
> -----------------------------------------------
>
> Key: DRILL-7330
> URL: https://issues.apache.org/jira/browse/DRILL-7330
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Arina Ielchiieva
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: 1.18.0
>
>
> 1. Change the current group scan to leverage Schema from Metastore;
> 2. Use stats for enabling additional logical planning rules for text format
> plugin. It will enable such optimizations as limit, filter push and so on.
> + add possibility to pass schema through schema file (using path or table
> root), inline.
> + check for other enhancements in analyze command
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
