[
https://issues.apache.org/jira/browse/DRILL-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062148#comment-17062148
]
ASF GitHub Bot commented on DRILL-7330:
---------------------------------------
paul-rogers commented on pull request #2026: DRILL-7330: Implement metadata
usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r394689649
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/metastore/store/SimpleFileTableMetadataProvider.java
##########
@@ -97,47 +100,38 @@ public FileMetadata getFileMetadata(Path location) {
@Override
public NonInterestingColumnsMetadata getNonInterestingColumnsMetadata() {
- return null;
+ return new NonInterestingColumnsMetadata(Collections.emptyMap());
Review comment:
Better name? `NonInteresting` --> `Uninteresting`?
But, why are they not interesting? Is it because they we don't track their
statistics? Is so, maybe we can define a term "tracked? untracked?" to describe
those columns which do (or do not) participate in statistics. I did a quick
check or Oracle, Postgres and SqlServer, but I didn't find a good term. Maybe
"excluded columns"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement metadata usage for text format plugin
> -----------------------------------------------
>
> Key: DRILL-7330
> URL: https://issues.apache.org/jira/browse/DRILL-7330
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Arina Ielchiieva
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: 1.18.0
>
>
> 1. Change the current group scan to leverage Schema from Metastore;
> 2. Use stats for enabling additional logical planning rules for text format
> plugin. It will enable such optimizations as limit, filter push and so on.
> + add possibility to pass schema through schema file (using path or table
> root), inline.
> + check for other enhancements in analyze command
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
